Skip to content

[ci] Run the tests on pull requests into the 1345-mass-command-admin-workflow branch - #1485

Closed
dee077 wants to merge 1 commit into
masterfrom
ci/run-tests-on-1345-pull-requests
Closed

dee077 wants to merge 1 commit into
masterfrom
ci/run-tests-on-1345-pull-requests

Conversation

@dee077

@dee077 dee077 commented Sep 14, 2026

Copy link
Copy Markdown
Member

Checklist

Description of Changes

  • Add feature/1345-mass-command-admin-workflow to ci
  • If we rename the branch, the PRs will lose their heads and get closed, and all our work on reviews will be lost, and we will have to open 2 new PRs

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 24f78922-7610-40fc-ab70-09b32f3f55c2

📥 Commits

Reviewing files that changed from the base of the PR and between 2912b57 and 9470bba.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: Python==3.10 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=5.1.0
  • GitHub Check: Python==3.13 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=5.2.0
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.13 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=5.2.0
  • GitHub Check: Python==3.11 | django~=5.1.0
🧰 Additional context used
📓 Path-based instructions (1)
Do not complain about dependencies installed from controlled mutable OpenWISP branches.

⚙️ CodeRabbit configuration file

Files:

  • .github/workflows/ci.yml
🪛 zizmor (1.29.0)
.github/workflows/ci.yml

[warning] 2-112: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)


[warning] 4-15: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting

(concurrency-limits)


📝 Walkthrough

Walkthrough

The GitHub Actions CI workflow now runs for pull requests targeting feature/1345-mass-command-admin-workflow, in addition to its existing branch targets.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: pandafy

Merge Risk: ⚪ Minimal · up to 9470b

CI will run for pull requests targeting the intended feature branch. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required [ci] prefix and clearly describes the CI workflow change for pull requests targeting the specified branch.
Description check ✅ Passed The description explains the CI change and its purpose. It includes the checklist, but it omits the required issue reference and does not mark non-applicable test, documentation, or screenshot items a…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Ui Changes, Regression Test, Docs ✅ Passed PASS. The pull request changes only .github/workflows/ci.yml and adds one pull_request.branches entry. This is a CI configuration change, not an end-user UI change or application feature. The cust…

Comment @coderabbitai help to get the list of available commands.

@dee077

dee077 commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Handled in #1420

@dee077 dee077 closed this Sep 14, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.362%. remained the same — ci/run-tests-on-1345-pull-requests into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants