[fix] UI and some minor issues

Author: dee077

openwisp_controller/connection/admin.py

@@ -11,7 +11,7 @@
 from django.core.exceptions import ObjectDoesNotExist, PermissionDenied, ValidationError
 from django.core.paginator import EmptyPage, PageNotAnInteger, Paginator
 from django.db.models import Count, Q
-from django.http import HttpResponseForbidden, JsonResponse
+from django.http import HttpResponseForbidden, HttpResponseNotAllowed, JsonResponse
 from django.shortcuts import redirect
 from django.template.response import TemplateResponse
 from django.urls import path, resolve
@@ -73,7 +73,7 @@ class Meta:
             "location",
         ]
         widgets = {
-            "label": forms.TextInput(attrs={"class": "vTextField"}),
+            "label": forms.TextInput(attrs={"class": "vTextField ow-text-field"}),
             "notes": forms.Textarea(attrs={"rows": 3}),
             "input": BatchCommandSchemaWidget,
             "group": OrganizationScopedSelect,
@@ -508,6 +508,8 @@ def execute_command_view(self, request):
         A valid submission goes to the session and redirects to the confirm
         page, so that its device table can be paginated with plain GETs.
         """
+        if request.method not in ("GET", "POST"):
+            return HttpResponseNotAllowed(["GET", "POST"])
         self._check_add_permission(request)
         if request.method == "POST":
             form = BatchCommandExecutionForm(request.POST, request=request)
@@ -524,9 +526,6 @@ def execute_command_view(self, request):
             "title": _("Execute mass command"),
             "opts": self.opts,
             "form": form,
-            # not combined with self.media: ModelAdmin.media loads
-            # jquery.init.js before select2, the opposite of what select2
-            # needs (see BatchCommandExecutionForm.Media)
             "media": form.media,
             "has_view_permission": self.has_view_permission(request),
         }
@@ -536,6 +535,8 @@ def confirm_command_view(self, request):
         """Second step: review the targeted devices and dispatch the command.
         Dispatching is decided by the HTTP method alone.
         """
+        if request.method not in ("GET", "POST"):
+            return HttpResponseNotAllowed(["GET", "POST"])
         self._check_add_permission(request)
         if request.method == "POST":
             return self._execute_batch_command(request)

openwisp_controller/connection/static/connection/css/batch-command.css

@@ -245,7 +245,7 @@
   text-align: center;
   width: 2rem;
 }
-.execute-form .submit-row {
+#main .execute-form .submit-row {
   display: flex;
   gap: 0.5rem;
   justify-content: flex-end;
@@ -306,3 +306,6 @@
 .execute-batch-command .form-row.field-input.errors .flex-container {
   display: none;
 }
+#main .form-row .ow-text-field {
+  width: 320px;
+}

openwisp_controller/connection/templates/admin/connection/batch_command/execute_command.html

@@ -30,7 +30,7 @@
 
 {% block content %}
 <div id="content-main">
-  <form method="post" novalidate>
+  <form method="post" novalidate class="execute-form">
     {% csrf_token %}
     <nav class="stepper" aria-label="{% trans 'Execution progress' %}">
       <div class="stepper-step active" aria-current="step">