Skip to content

Commit d9bf525

Browse files
committed
suggested edits from PR#2292
1 parent 9f47d43 commit d9bf525

File tree

3 files changed

+8
-21
lines changed

3 files changed

+8
-21
lines changed

conf/authen_CAS.conf.dist

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,7 @@ $authen{user_module} = {
1616
# This should be a non-empty sublist of whatever is in $authen{user_module}.
1717
# Since the admin course provides overall power to add/delete courses, access
1818
# to this course should be protected by the best possible authentication you
19-
# have available to you. The current default is
20-
# WeBWorK::Authen::Basic_TheLastOption which is simple password based
21-
# authentication for a password locally stored in your WeBWorK server's
22-
# database. On one hand, this is necessary as the initial setting, as it is the
23-
# only option available when a new server is being installed. However, since
24-
# this option does not make use of multi-factor authentication or provide any
25-
# capabilities to prevent dictionary attacks, etc. At the very least you should
26-
# use a very strong password. If you have the option to use a more secure
27-
# authentication approach to the admin course (one which you are confident
28-
# cannot be spoofed) that is preferable.
19+
# have available to you.
2920
$authen{admin_module} = [
3021
'WeBWorK::Authen::CAS'
3122
];

conf/authen_ldap.conf.dist

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,7 @@ $authen{user_module} = {
1616
# This should be a non-empty sublist of whatever is in $authen{user_module}.
1717
# Since the admin course provides overall power to add/delete courses, access
1818
# to this course should be protected by the best possible authentication you
19-
# have available to you. The current default is
20-
# WeBWorK::Authen::Basic_TheLastOption which is simple password based
21-
# authentication for a password locally stored in your WeBWorK server's
22-
# database. On one hand, this is necessary as the initial setting, as it is the
23-
# only option available when a new server is being installed. However, since
24-
# this option does not make use of multi-factor authentication or provide any
25-
# capabilities to prevent dictionary attacks, etc. At the very least you should
26-
# use a very strong password. If you have the option to use a more secure
27-
# authentication approach to the admin course (one which you are confident
28-
# cannot be spoofed) that is preferable.
19+
# have available to you.
2920
$authen{admin_module} = [
3021
'WeBWorK::Authen::LDAP'
3122
];

lib/WeBWorK/Authen.pm

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,12 @@ sub verify {
191191

192192
my $authen_ref = ref($c->authen);
193193
if ($c->ce->{courseName} eq 'admin' && !(grep(/^$authen_ref$/, @{ $c->ce->{authen}{admin_module} }))) {
194-
$c->stash(authen_error => maketext("Cannot authenticate into admin course using $authen_ref."));
194+
$self->write_log_entry("Cannot authenticate into admin course using $authen_ref.");
195+
$c->stash(
196+
authen_error => $c->maketext(
197+
'There was an error during the login process. Please speak to your instructor or system administrator.'
198+
)
199+
);
195200
return ($self->call_next_authen_method());
196201
}
197202

0 commit comments

Comments
 (0)