Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection animation is broken - no spinner or SVG image #1314

Open
3 tasks
timbl-ont opened this issue Nov 13, 2024 · 1 comment
Open
3 tasks

Connection animation is broken - no spinner or SVG image #1314

timbl-ont opened this issue Nov 13, 2024 · 1 comment

Comments

@timbl-ont
Copy link
Contributor

Description of problem

The animation on the connection screen is not displaying a spinner or the appropriate SVG icon. See screen shot

Expected behavior

The animated activity spinner is shown along with a SVG icon in the middle of the spinner.

Steps to reproduce

Issue a credential to the wallet

Screenshots and/or log output

Screenshot_20241105-164817 (1)

Environment

  • [X ] Occurs on Android
  • Occurs on iOS

Build #: v1.0.0-alpha.366

Android Device Model:
Google Pixel 6

iOS Device Model:

Workaround

Severity

  • High
  • [X ] Medium
  • Low
@timbl-ont
Copy link
Contributor Author

@jleach I did not realize this was intentional to implement skeleton loading - so not a bug. I just assumed it was something odd in the animation.

Having said that, I am not sure if this works well for this use case especially with longer loading times. The overall effect seems more jarring than a smooth transition.

Perhaps there are some tweaks that would help. Some thoughts:

  1. The yellow bar moves very slowly compared to the time on the skeleton screen
  2. The skeleton does not always align well with the final content as the page that is loaded is not fixed. It is impacted by the number of credentials, OCA, and credential protocol (DIDComm, OpenID4VC ...)
  3. It looks like the final screen loads with an animation (from the bottom, I think?) that breaks the smooth transition effect.
  4. The cancel button mid screen also breaks the smooth transition to the final screen.

Happy to help contribute, but not sure if this is still a work in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant