Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create some tests #35

Open
3 tasks
waldoj opened this issue Dec 25, 2017 · 2 comments
Open
3 tasks

Create some tests #35

waldoj opened this issue Dec 25, 2017 · 2 comments

Comments

@waldoj
Copy link
Member

waldoj commented Dec 25, 2017

  • grab some sample CSV files to test against
  • import CSV to the database
  • make sure there is a photo of every legislator
@waldoj
Copy link
Member Author

waldoj commented Dec 25, 2017

So what are the things that fail the most on the parser?

Realistically...not much. It's really resilient.

Maybe a better purpose for tests is to make it easier to swap out components.

@waldoj
Copy link
Member Author

waldoj commented Feb 2, 2018

Use PHPUnit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant