Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from Travis #755

Open
6 of 8 tasks
waldoj opened this issue Oct 17, 2021 · 4 comments
Open
6 of 8 tasks

Move away from Travis #755

waldoj opened this issue Oct 17, 2021 · 4 comments
Labels

Comments

@waldoj
Copy link
Member

waldoj commented Oct 17, 2021

Travis is now Actually Bad. Also, I cannot get clean builds anymore, due to goofy errors that I gather are becoming more common with Travis. I haven't been able to deploy for months. Instead of fighting a series of little fires, better to complete the frustrating task of rewriting the Travis script for Circle or GitHub Actions.

  • get a version of the build/deploy config so that it can run without errors
  • add every secret from Travis into GitHub
  • restore testing
  • enable running builds (not not deploys) on PRs
  • test and debug cautiously, reviewing all GitHub Actions output
  • permit the script to function on the deploy branch
  • add status badge to README
  • repeat all of this for rs-api and rs-machine
@waldoj waldoj added the devops label Oct 17, 2021
@waldoj
Copy link
Member Author

waldoj commented Oct 17, 2021

This Travis -> GitHub Actions converter should make this a lot easier. It's far from complete, in what it can auto-convert, but it's a start.

@waldoj
Copy link
Member Author

waldoj commented Nov 29, 2021

Well, that was a start, but not enough of one. So I'm starting from scratch. I'm leaning on these two resources: Migrate From Travis CI to GitHub Actions and Amazon EC2 Deployment: Complete CI/CD Pipeline using GitHub Actions and AWS CodeDeploy.

@waldoj
Copy link
Member Author

waldoj commented Nov 29, 2021

Well, I got a successful deploy...but it deployed the staging site to deploy, which...🤯

waldoj added a commit that referenced this issue Nov 30, 2021
This will solve the problem of staging deploying to production. Toward #755.
@waldoj
Copy link
Member Author

waldoj commented Nov 30, 2021

I've got two problems that I think are the same problem.

In build, we move the environment-specific appspec to appspec.yml, so that CodeDeploy will use that...but that file is missing from the actual deploy bundle sent to AWS, so the deploy fails.

And in deploy, we start with uses: actions/checkout@v2, and the log shows that, indeed, the repo is being checked out. Which is sensible enough, but that means that none of the steps in the build process are persisting to the deploy step, which is, of course, bad.

I think the solution to both of these things is to replace that pasted-in step with something that will instead draw on the output of the build step.

waldoj added a commit that referenced this issue Dec 3, 2021
waldoj added a commit that referenced this issue Dec 3, 2021
waldoj added a commit that referenced this issue Dec 4, 2021
waldoj added a commit that referenced this issue Dec 6, 2021
waldoj added a commit that referenced this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant