Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash passwords better #330

Open
4 tasks
waldoj opened this issue Jun 13, 2019 · 1 comment
Open
4 tasks

Hash passwords better #330

waldoj opened this issue Jun 13, 2019 · 1 comment

Comments

@waldoj
Copy link
Member

waldoj commented Jun 13, 2019

All passwords are hashed with md5(), which is not appropriate in 2019. It was barely appropriate in 2006 (when the code was written). PHP has native password functionality — use that.

  • write a method to salt & hash passwords
  • store the salt in Travis CI, to copy to the settings during the deploy
  • write a method to compare passwords to the hash (e.g. on login)
  • figure out what to do about all of the passwords already stored in the database
@waldoj
Copy link
Member Author

waldoj commented Jun 13, 2019

Realistically, I think we'll need two, side-by-side password systems. New accounts use the new one. Anybody logging into a legacy account will, invisibly, have their password re-hashed and stored in the new system, and then have their old password wiped. After ~14 months, I think then it's time to zero out any legacy passwords — at that point, those folks can just use the "forgot my password" link to get into their accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant