Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lousy geodata file hack #78

Open
waldoj opened this issue Oct 30, 2014 · 0 comments
Open

Replace lousy geodata file hack #78

waldoj opened this issue Oct 30, 2014 · 0 comments

Comments

@waldoj
Copy link
Member

waldoj commented Oct 30, 2014

Instead of finding all address-data fields in the field maps in Crump, instead we just explicitly look for file numbers 2, 3, or 9, and manually concatenate the relevant fields. This is not the right way to do this.

Instead, figure out how to maintain dict order, to get the address in the proper order. (e.g., "Charlottesville, 123 Main St., 22902, VA.") My guess is that we can use the order of the fields in the YAML files as an external ordering reference. Once we do that, we can find all groups with "address" in their name and "geo_" in search > type, and combine those fields to hash them.

waldoj added a commit that referenced this issue Nov 11, 2014
This is basically a hack that’ll need to be fixed later, per #78.

Closes #82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant