Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "transcript" a full URL, not just a path #5

Open
reefdog opened this issue Mar 11, 2023 · 2 comments
Open

Make "transcript" a full URL, not just a path #5

reefdog opened this issue Mar 11, 2023 · 2 comments

Comments

@reefdog
Copy link

reefdog commented Mar 11, 2023

First, amazing work! 👏

Second, I recommend changing the transcript attribute to return a full URL, not just a path. This makes it a little easier to use because the client only needs the JSON, not information about where the JSON came from.

This does slightly complicate generation since you either have to hardcode in the domain (drake no) or make it reliant on an env var (drake aha) but that seems like a worthwhile trade-off.

Happy to submit this as a PR if desired.

jq "map(if .case_id == \"$case\" then . + {\"transcript\": \"/transcripts/$case.srt\"} else . end)" arguments.json > "$tmp" && mv "$tmp" arguments.json

@waldoj
Copy link
Member

waldoj commented Mar 11, 2023

I intend to do that, but haven't yet because there's a decent chance that I'll register a domain for this in the next few day. :)

@reefdog
Copy link
Author

reefdog commented Mar 11, 2023

Oh! I figured courtaudio.openva.com was canonical. Sure, wait until then. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants