should we dump UCT componet device type?

[Honggang-LI]

hi,

diff --git a/src/tools/info/tl_info.c b/src/tools/info/tl_info.c
index 5f675a96e..e9c1df674 100644
--- a/src/tools/info/tl_info.c
+++ b/src/tools/info/tl_info.c
@@ -114,6 +114,12 @@ static const char *size_limit_to_str(size_t min_size, size_t max_size)
 
     return buf;
 }
+static const char * ucp_device_type_names[] = {
+    [UCT_DEVICE_TYPE_NET]  = "network",
+    [UCT_DEVICE_TYPE_SHM]  = "intra-node",
+    [UCT_DEVICE_TYPE_ACC]  = "accelerator",
+    [UCT_DEVICE_TYPE_SELF] = "loopback",
+};
 
 static void print_iface_info(uct_worker_h worker, uct_md_h md,
                              uct_tl_resource_desc_t *resource)
@@ -145,6 +151,7 @@ static void print_iface_info(uct_worker_h worker, uct_md_h md,
 
     printf("#      Transport: %s\n", resource->tl_name);
     printf("#         Device: %s\n", resource->dev_name);
+    printf("#           Type: %s\n", ucp_device_type_names[resource->dev_type]);
     printf("#  System device: %s",
            ucs_topo_sys_device_get_name(resource->sys_device));
     if (resource->sys_device != UCS_SYS_DEVICE_ID_UNKNOWN) {

With this simple patch, we can get the component device type.

ucx (master *)]$ /tmp/ucx/bin/ucx_info -d | grep Type -B 2
#      Transport: posix
#         Device: memory
#           Type: intra-node
--
#      Transport: sysv
#         Device: memory
#           Type: intra-node
--
#      Transport: self
#         Device: memory0
#           Type: loopback
--
#      Transport: tcp
#         Device: eno1
#           Type: network
--
#      Transport: tcp
#         Device: lo
#           Type: network
--
#      Transport: cma
#         Device: memory
#           Type: intra-node

should we dump UCT component device type?

thanks

[yosefe]

Yes, it would be good to dump it. However i'd move ucp_device_type_names to UCS: rename to ucs_device_type_names and move to src/uct/base/uct_md.c and uct/api/uct.h. Then use it from UCP and tl_info

[Honggang-LI]

rename to ucs_device_type_names and move to src/uct/base/uct_md.c and uct/api/uct.h.

I think it is better to rename as uct_device_type_names as it in src/uct instead of src/ucs.

[yosefe]

right, uct_device_type_names is better

[Honggang-LI]

#7555