Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TracingInterceptor to decorate Span when exception occurs #147

Open
rafaelbey opened this issue Sep 15, 2021 · 1 comment
Open

Comments

@rafaelbey
Copy link
Collaborator

Currently, the TracingInterceptor just add the error tag whenever an exception occurs.

I will like to be able to decorate the Span with other details about the exception, like the exception message. This will help our users find errors specially when exceptions are thrown while streaming data, where the response is just an incomplete stream, and have little detail on the underlying cause.

One idea I can think is to enhance the InterceptorSpanDecorator to have two new methods: decorateReadException and decorateWriteException, and call these when an error is catch. I will submit a PR with this idea shortly to better visualize it.

@rafaelbey
Copy link
Collaborator Author

Any feedback and direction will be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant