-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass Intel Driver bugs in driver v32.0.101.6557 (see remarks) #152
Open
Xerxes004
wants to merge
10
commits into
opentk:master
Choose a base branch
from
Xerxes004:intel-bug-bypass
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit circumvents two errors with Intel drivers: 1) A D3D9 surface cannot be registered as a Renderbuffer target 2) A D3D9 surface cannot be created with MSAA enabled The Intel drivers have a bug where a D3D9 surface registered as a Renderbuffer target type accesses memory out of range. There are a host of theories as to why this is, but this commit bypasses using a Renderbuffer target in lieu of a Texture2D target. For depth testing and MSAA to work as intended, the user must create their own framebuffers with these attachments.
Xerxes004
commented
Feb 11, 2025
Xerxes004
commented
Feb 17, 2025
GL.BindTexture(TextureTarget.Texture2D, GLBlitTextureHandle); | ||
GL.TexImage2D(TextureTarget.Texture2D, | ||
0, | ||
PixelInternalFormat.Rgba32f, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use unsigned byte pixels instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit circumvents two errors with Intel drivers:
The Intel drivers have a bug where a D3D9 surface registered as a Renderbuffer target type accesses memory out of range. There are a host of theories as to why this is, but this commit bypasses using a Renderbuffer target in lieu of a Texture2D target.
For depth testing and MSAA to work as intended, the user must create their own framebuffers with these attachments.