You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When using the -Wundef flag the following flags show up to have no default:
OPENTHREAD_ENABLE_VENDOR_EXTENSION
OPENTHREAD_EXAMPLES_SIMULATION
OPENTHREAD_CONFIG_PLATFORM_BOOTLOADER_MODE_ENABLE
Blocks using -Werror in a build + currently these flags need to be added as dummy 0 in a config .h
To Reproduce Information to reproduce the behavior, including:
Was added a very long time ago
IEEE 802.15.4 hardware platform - any
Build steps - normal build with none of the mentioned flags in the configuration header
Network topology - NA
Expected behavior
Build does not throw 'undefined' warning
Additional context
There is no default for the mentioned flags defined in code. The define is only generated in CMake options - also no fallback there to 0. Adding a #if !defined construction as done for other config's in the common headers would fix this
The text was updated successfully, but these errors were encountered:
tima-q
changed the title
-Wundef - no default for OPENTHREAD_ENABLE_VENDOR_EXTENSION
-Wundef - no default for OPENTHREAD_ENABLE_VENDOR_EXTENSION/OPENTHREAD_EXAMPLES_SIMULATION
Nov 21, 2023
Describe the bug
When using the -Wundef flag the following flags show up to have no default:
OPENTHREAD_ENABLE_VENDOR_EXTENSION
OPENTHREAD_EXAMPLES_SIMULATION
OPENTHREAD_CONFIG_PLATFORM_BOOTLOADER_MODE_ENABLE
Blocks using -Werror in a build + currently these flags need to be added as dummy 0 in a config .h
To Reproduce Information to reproduce the behavior, including:
Expected behavior
Build does not throw 'undefined' warning
Additional context
There is no default for the mentioned flags defined in code. The define is only generated in CMake options - also no fallback there to 0. Adding a #if !defined construction as done for other config's in the common headers would fix this
The text was updated successfully, but these errors were encountered: