-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global element versioning #4660
Comments
I'm not sure how feasible this is from a total runtime point of view. In any case, mass updating old element tables is probably bad news for our minutely diff replication, since it would end up generating billions of entries in our replication log files. I haven't tested it, but I believe it would bring minutely diff replication to a standstill for quite some time. The original use case for old element updates was to support redaction, which is rather low data volume. Also, we're not using this information at the moment. By the way, I'm well aware that the additional sorting in both implementations would not necessarily match the original upload sequence. However, I never really had the expectation that it should. |
Problem
Sometimes the code tries to reproduce the sequence of element modifications but the data to do this is not directly available.
Changeset downloads rely primarily on timestamps, and then additionally sort by version, type etc and it's done differently in osm-website and cgimap. This additional ordering may not be correct. For example, it makes sense to reverse ordering by type for deletions. Relying on the additional ordering becomes necessary if timestamps are truncated, and that may happen if the data is restored from a dump.
Changeset webpages show lists elements. Those also reproduce the modification sequence in most of the cases but that happens as a side-effect of them not being sorted. This lack of sorting causes problems elsewhere and so does assuming that the elements are not sorted, see #4571.
Description
Is it feasible to do this thing?
openstreetmap-website/app/controllers/api/changesets_controller.rb
Lines 154 to 157 in 0c4cbda
Screenshots
No response
The text was updated successfully, but these errors were encountered: