Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor-layer-index at npm was taken down, claimed to be containing malware, npm audit gives scary warning on install #10772

Open
matkoniecz opened this issue Feb 15, 2025 · 5 comments
Labels
question Not Actionable - just a question about something

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Feb 15, 2025

As I understand: at some point https://www.npmjs.com/package/editor-layer-index was taken down. Maybe it actually had malware.

https://github.com/openstreetmap/iD/blob/develop/package.json#L101C28-L101C69 points not to NPM but to github

"editor-layer-index": "github:osmlab/editor-layer-index#gh-pages",

but npm audit does npm audit things and emits scary warning linking GHSA-jq9w-gjvg-mxr8

Image

Is it avoidable somehow? It is definitely scary for new contributors

@matkoniecz matkoniecz changed the title editor-layer-index at npm was taken down for containing malware, npm audit gives scary warning on install editor-layer-index at npm was taken down, claimed to be containing malware, npm audit gives scary warning on install Feb 15, 2025
@andrewharvey
Copy link
Contributor

I don't think osmlab/editor-layer-index ever published to the npmjs.com registry. I think what happened is someone else published malware into the untaken namespace to try and catch unsuspecting developers trying to npm install from the registry instead of directly from github.com/osmlab/editor-layer-index.

Then the npmjs team took over the package.

IT looks like a bug in npm audit, if we never request a package from npmjs.com within package.json, why is it reporting security issues relating to it.

@tyrasd tyrasd added the question Not Actionable - just a question about something label Feb 15, 2025
@tyrasd
Copy link
Member

tyrasd commented Feb 15, 2025

Oh, this is really unfortunate. Does anyone have experience with such situations? Could it be worth trying to contact npm's support (perhaps via https://support.github.com/contact/npm-name-disputes maybe??) to get this transferred?

Alternatively, we'd have to either live with the false positive produced by npm audit, or rename the package to something like @openstreetmap/editor-layer-index (and put a dummy/NOP version in its place on npm for it) and ask existing users to switch.

@matkoniecz
Copy link
Contributor Author

Could it be worth trying to contact npm's support (perhaps via https://support.github.com/contact/npm-name-disputes maybe??)

I can try - if you think it is a good idea, can you post that here so I will have evidence that my request is coming from the project, not another hijacker?

@tyrasd
Copy link
Member

tyrasd commented Feb 17, 2025

It's probably more effective if I try, as I'm already member of all relevant npm and github organizations/repos. Or do you prefer to take care of this @andrewharvey?

@andrewharvey
Copy link
Contributor

It's probably more effective if I try, as I'm already member of all relevant npm and github organizations/repos. Or do you prefer to take care of this @andrewharvey?

Nope all yours @tyrasd, agreed probably more effective coming through you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Not Actionable - just a question about something
Projects
None yet
Development

No branches or pull requests

3 participants