Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember last used Map Data options #10673

Open
gy-mate opened this issue Jan 12, 2025 · 7 comments
Open

Remember last used Map Data options #10673

gy-mate opened this issue Jan 12, 2025 · 7 comments
Labels
usability An issue with ease-of-use or design

Comments

@gy-mate
Copy link

gy-mate commented Jan 12, 2025

Description

I always turn on OpenStreetMap Notes and I also often use all Photo Overlays. It's quite inconvenient to turn these on every time I open iD with the openstreetmap.org Edit button. It would be nice if these settings would be saved and reapplied automatically.

iD version: 2.30.4

Related issue: #8665

Screenshots

Screenshot 2025-01-12 at 11 25 20
@KatalKavya96
Copy link

@gy-mate I have understood the issue and believe I can implement a solution that remembers overlay presets and applies them every time the map is used. I have started thinking through the approach and am confident I can work on this.
Could you please assign me this issue?

@gy-mate
Copy link
Author

gy-mate commented Jan 13, 2025

@KatalKavya96 I don't have permission to do that but you can work on it anyway!

@tyrasd tyrasd added the usability An issue with ease-of-use or design label Jan 14, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 14, 2025

I have started thinking through the approach

@KatalKavya96 can you please explain your thought process please?

@ChaitanyaKadu03
Copy link
Contributor

@tyrasd Would you like me to proceed with this issue? I'm planning to store and retrieve the user’s preferred overlays using either cookies or local storage so they're automatically re-applied whenever iD is opened. If that sounds good, I'd be happy to detail the process further once I have your go-ahead. Thanks!

@Suvendu-UI
Copy link

@gy-mate i think @tyrasd had already closed similar issue for this reason "
🤔 I'm hesitating because this "fix" will have the major downside that after any (global) background layer was been chosen, from that point onward, there would never be a situation where the best imagery is preferred over the "last used" layer. The intention of the best flag is however to have layers which are known to be better than the global default layers in their respective regions. Therefore they should be actually get precedence over other layers.

Surely, there are situations where a user manually selects a non-best layer in a specific region for a specific reason and would prefer that this layer is loaded on further sessions in this area (but not in other areas where a different best layer exists). Unfortunately, it's not trivial to implement a mechanism which would remember that user's preference on a per-region basis (and/or on a per overridden best layer basis). For now, there exists the following workaround for users: bookmark a specific location requesting the preferred background layer via a hash parameter, e.g. http://localhost:8080/#background=Maxar-Premium&disable_features=boundaries&map=19.50/-36.81455/174.80295 or https://www.openstreetmap.org/edit#map=19/-36.81455/174.80295&background=Maxar-Premium

"

@gy-mate
Copy link
Author

gy-mate commented Jan 29, 2025

@Suvendu-UI Which issue was this?

@DujaOSM
Copy link

DujaOSM commented Jan 30, 2025

I see that as an edge case that should not block implementation of the feature. First, most mappers seldom go out of their preferred region to do armchair mapping. Those who do are usually aware of possible existence of better background layers in other regions, and [B] is one keypress away to check that out. The "best" flag should be clearly indicated on the layer list, if it isn't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

6 participants