Skip to content

Commit a5b385d

Browse files
committed
(backport) resolve crossreferenced subtiles of base presets of NSI, v2.37.2
1 parent a5af9e6 commit a5b385d

File tree

8 files changed

+24
-13
lines changed

8 files changed

+24
-13
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,13 @@ _Breaking developer changes, which may affect downstream projects or sites that
3535
[@xxxx]: https://github.com/xxxx
3636
-->
3737

38+
# 2.37.2
39+
##### 2025-10-30
40+
41+
* Correctly resolve subtitles of NSI presets when base preset has a crossreferenced string ([11527])
42+
43+
[#11527]: https://github.com/openstreetmap/iD/issues/11527
44+
3845

3946
# v2.37.1
4047
##### 2025-10-27

dist/iD.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8706,7 +8706,7 @@
87068706
// package.json
87078707
var package_default = {
87088708
name: "iD",
8709-
version: "2.37.1",
8709+
version: "2.37.2",
87108710
description: "A friendly editor for OpenStreetMap",
87118711
main: "dist/iD.min.js",
87128712
repository: "github:openstreetmap/iD",
@@ -23642,15 +23642,17 @@
2364223642
if (_this.suggestion) {
2364323643
let path = presetID.split("/");
2364423644
path.pop();
23645-
return _t("_tagging.presets.presets." + path.join("/") + ".name");
23645+
const basePreset = allPresets[path.join("/")];
23646+
return basePreset.name();
2364623647
}
2364723648
return null;
2364823649
};
2364923650
_this.subtitleLabel = () => {
2365023651
if (_this.suggestion) {
2365123652
let path = presetID.split("/");
2365223653
path.pop();
23653-
return _t.append("_tagging.presets.presets." + path.join("/") + ".name");
23654+
const basePreset = allPresets[path.join("/")];
23655+
return basePreset.nameLabel();
2365423656
}
2365523657
return null;
2365623658
};

dist/iD.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/iD.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/iD.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/presets/preset.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,8 @@ export function presetPreset(presetID, preset, addable, allFields, allPresets) {
126126
if (_this.suggestion) {
127127
let path = presetID.split('/');
128128
path.pop(); // remove brand name
129-
return t('_tagging.presets.presets.' + path.join('/') + '.name');
129+
const basePreset = allPresets[path.join('/')];
130+
return basePreset.name();
130131
}
131132
return null;
132133
};
@@ -135,7 +136,8 @@ export function presetPreset(presetID, preset, addable, allFields, allPresets) {
135136
if (_this.suggestion) {
136137
let path = presetID.split('/');
137138
path.pop(); // remove brand name
138-
return t.append('_tagging.presets.presets.' + path.join('/') + '.name');
139+
const basePreset = allPresets[path.join('/')];
140+
return basePreset.nameLabel();
139141
}
140142
return null;
141143
};

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "iD",
3-
"version": "2.37.1",
3+
"version": "2.37.2",
44
"description": "A friendly editor for OpenStreetMap",
55
"main": "dist/iD.min.js",
66
"repository": "github:openstreetmap/iD",

0 commit comments

Comments
 (0)