Merge pull request #540 from DroidsOnRoids/rejected-email-template

koral-- · web-flow · commit f940e0cd2f1d · 2020-02-26T01:16:54.000+01:00
Rejected email hardcoded HTML replaced with template.
diff --git a/lib/units/auth/oauth2/index.js b/lib/units/auth/oauth2/index.js
@@ -57,8 +57,7 @@ module.exports = function(options) {
       }
       else {
         log.warn('Missing or disallowed email in profile', req.user)
-        res.send('<html><body>Missing or rejected email address ' +
-                 '<a href="/auth/oauth/">Retry</a></body></html>')
+        res.render('rejected-email')
       }
     }
   )
diff --git a/res/app/views/rejected-email.pug b/res/app/views/rejected-email.pug
@@ -0,0 +1,10 @@
+doctype html
+html
+  head
+    meta(charset='utf-8')
+    base(href='/')
+    title("STF")
+  body
+    Missing or rejected email address
+    a(href='/auth/oauth/')
+      Retry

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,7 @@ module.exports = function(options) {`
`57`	`57`	`}`
`58`	`58`	`else {`
`59`	`59`	`log.warn('Missing or disallowed email in profile', req.user)`
`60`		`- res.send('<html><body>Missing or rejected email address ' +`
`61`		`- '<a href="/auth/oauth/">Retry</a></body></html>')`
	`60`	`+ res.render('rejected-email')`
`62`	`61`	`}`
`63`	`62`	`}`
`64`	`63`	`)`