Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement check in installer ensure admin rights, and warn about need for non-user writeable dir #551

Open
2 tasks
Tracked by #129
nhorman opened this issue May 13, 2024 · 1 comment
Assignees

Comments

@nhorman
Copy link
Contributor

nhorman commented May 13, 2024

we need to ensure the following:

  • That the windows installer is run in administrator context
  • Warn user that user should install openssl in a non-user writeable directory

I think the approach here is pretty straight forward.

NSIS offers support to check if we are running as admin:
https://nsis.sourceforge.io/Check_if_the_current_user_is_an_Administrator

So we can add that in to the installer script

NSIS also supports the IsWriteable macro to check the permissions on a directory
https://nsis.sourceforge.io/IsWritable

so we should be able to check if the target directory is only system writeable

@nhorman nhorman self-assigned this May 13, 2024
@mattcaswell
Copy link
Member

Including checking the config file is not user writeable

@nhorman nhorman changed the title Implement check in installer to ensure it is not installed to a user writeable location Implement check in installer ensure admin rights, and warn about need for non-user writeable dir May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants