[master] Add reason codes with the correct offset for two alerts #24351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openssl#24300. The current values of SSL_R_NO_APPLICATION_PROTOCOL and SSL_R_PSK_IDENTITY_NOT_FOUND don't allow for a correct lookup of the corresponding reason strings. CLA: trivial
2 tasks
t8m
added
branch: master
t8m
approved these changes
May 9, 2024
t8m
removed
the
approval: otc review pending
github-actions
bot
added
severity: fips change
shahsb
approved these changes
May 9, 2024
|
ping for the second review |
mattcaswell
approved these changes
May 13, 2024
mattcaswell
added
approval: done
|
Ok with CLA: trivial |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
May 14, 2024
Fixes #24300. The current values of SSL_R_NO_APPLICATION_PROTOCOL and SSL_R_PSK_IDENTITY_NOT_FOUND don't allow for a correct lookup of the corresponding reason strings. CLA: trivial Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24351)
|
Merged to the master, 3.3 and 3.2 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
May 14, 2024
Fixes #24300. The current values of SSL_R_NO_APPLICATION_PROTOCOL and SSL_R_PSK_IDENTITY_NOT_FOUND don't allow for a correct lookup of the corresponding reason strings. CLA: trivial Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24351) (cherry picked from commit a401aaf)
openssl-machine
pushed a commit
that referenced
this pull request
May 14, 2024
Fixes #24300. The current values of SSL_R_NO_APPLICATION_PROTOCOL and SSL_R_PSK_IDENTITY_NOT_FOUND don't allow for a correct lookup of the corresponding reason strings. CLA: trivial Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24351) (cherry picked from commit a401aaf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward-port of #24338.
Fixes #24300. The current values of
SSL_R_NO_APPLICATION_PROTOCOLandSSL_R_PSK_IDENTITY_NOT_FOUNDdon't allow for a correct lookup of the corresponding reason strings.Checklist
documentation is added or updatedtests are added or updated