Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI4: Export of Customer Data to JSON format does not respect numberformat local #3888

Open
objecttothis opened this issue Dec 7, 2023 · 1 comment
Assignees
Labels
bug CodeIgniter4 Issue relates to the conversion to CodeIgniter 4
Milestone

Comments

@objecttothis
Copy link
Member

numberformat
thousands separator: period .
decimal separator: comma ,

In the customer view, if you click the export icon and choose JSON, the resulting JSON for the amount spent strips the comma (decimal separator) and treats the period (thousands separator) like a decimal.

The functionality is implemented by Bootstrap Table https://bootstrap-table.com/versions/1.15.5/. I wonder if a newer version is needed?

@objecttothis
Copy link
Member Author

I updated the bootstrap-table dependency in npm to 1.22.1 (latest) but no immediate effect. I probably need to log the data that gets sent to it to see if it's the json-encoded data that is a problem. I suspect it might be.

@objecttothis objecttothis self-assigned this Dec 7, 2023
@objecttothis objecttothis added the CodeIgniter4 Issue relates to the conversion to CodeIgniter 4 label Dec 12, 2023
@objecttothis objecttothis added this to the 3.4.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CodeIgniter4 Issue relates to the conversion to CodeIgniter 4
Projects
None yet
Development

No branches or pull requests

1 participant