New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-1.11-rebase: reenable event handling while image pruning #20127
Comments
/cc @openshift/sig-developer-experience |
we'll also need to fix this behavior in 3.10.z |
Does gonum/graph allow us to generate our own ids? |
Good idea. The generation is quite simple: https://github.com/openshift/origin/blob/master/vendor/github.com/gonum/graph/simple/directed.go#L51 We can use our own function though. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Underlying gonum/graph assigns conflicting IDs to new nodes after a node deletion. Thus two different nodes amy be assigned the same ID. This leads to panic when an edge is set between them.
The following PR temporarily disables event handling until the package is fixed. This ensures that no new nodes will be added to the graph after the first node gets removed.
deads2k#87
Either gonum/graph needs to be fixed or some replacement needs to be found.
The code is still buggy in 3.10 and needs to be fixed. The rebase just made the bug visible.
The text was updated successfully, but these errors were encountered: