Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32028: Decrease logs of haproxy #4245

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mkowalski
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-29919, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 6, 2024
@mkowalski
Copy link
Contributor Author

/cc @cybertron

@openshift-ci openshift-ci bot requested a review from cybertron March 6, 2024 15:43
@mkowalski
Copy link
Contributor Author

/retest-required

@zhaozhanqi
Copy link

@mkowalski sounds like below logs still print after changing to

# oc rsh -n openshift-kni-infra haproxy-master-0
Defaulted container "haproxy" out of: haproxy, haproxy-monitor, verify-api-int-resolvable (init)
sh-4.4$ cat /etc/haproxy/haproxy.cfg | grep log
  log     /var/run/haproxy/haproxy-log.sock local0 notice alert
  log-format "%ci:%cp -> %fi:%fp [%t] %ft %b/%s %Tw/%Tc/%Tt %B %ts %ac/%fc/%bc/%sc/%rc %sq/%bq"
  option  dontlognull
  option dontlognull
   option  log-health-checks



<134>Mar 12 01:41:01 haproxy[46]: ::ffff:192.168.111.1:53422 -> ::ffff:192.168.111.20:9445 [12/Mar/2024:01:40:28.063] main masters/master-1 1/0/33700 15180 -- 97/97/96/36/0 0/0
<134>Mar 12 01:41:03 haproxy[46]: ::ffff:192.168.111.25:49302 -> ::ffff:192.168.111.20:9445 [12/Mar/2024:01:41:03.173] main masters/master-0 1/0/4 2850 -- 98/98/97/53/0 0/0
<134>Mar 12 01:41:03 haproxy[46]: ::ffff:192.168.111.25:49304 -> ::ffff:192.168.111.20:9445 [12/Mar/2024:01:41:03.173] main masters/master-1 1/0/6 2858 -- 97/97/96/36/0 0/0
<134>Mar 12 01:41:05 haproxy[46]: ::ffff:192.168.111.1:47856 -> ::ffff:192.168.111.20:9445 [12/Mar/2024:01:41:04.228] main masters/master-2 1/0/1258 16319 -- 98/98/97/7/0 0/0

@mkowalski
Copy link
Contributor Author

I just modified to remove log-health-checks option. Maybe this is what was logged

@zhaozhanqi
Copy link

Yes, the logs do not show up after removing log-health-checks

Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 743fd42 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn 743fd42 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkowalski
Copy link
Contributor Author

/cc @cybertron

In my opinion access logs for haproxy are not really useful, I do not recall us ever looking into them

@mkowalski
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@mkowalski: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski mkowalski changed the title OCPBUGS-29919: Decrease logs of haproxy OCPBUGS-32028: Decrease logs of haproxy Apr 10, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-32028, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cybertron
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@openshift-bot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0968179 and 2 for PR HEAD 743fd42 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 23df276 into openshift:master Apr 11, 2024
16 of 18 checks passed
@openshift-bot
Copy link
Contributor

@mkowalski: Jira Issue OCPBUGS-32028: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32028 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@mkowalski: new pull request created: #4313

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202404102343.p0.g23df276.assembly.stream.el9 for distgit ose-machine-config-operator.
All builds following this will include this PR.

@mkowalski mkowalski deleted the OCPBUGS-29919b branch June 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants