Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of ./lib/* fork #819

Open
runcom opened this issue Jun 5, 2019 · 5 comments
Open

get rid of ./lib/* fork #819

runcom opened this issue Jun 5, 2019 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@runcom
Copy link
Member

runcom commented Jun 5, 2019 •
edited

This somehow depends on #588 but can be done w/o that finished as well. Code under ./lib is basically a fork of an old project that now fully lives in openshift/library-go.

We need to:

  • Fix move types to openshift/api #588 (but again, this issue can be done 99% w/o that)
  • Move existing code to use openshift/library-go/pkg/operator/resource/* for core types
  • drop ./lib

As of today, since #588 isn't done yet, we can work on the second point above as follows:

  • Move existing code to use openshift/library-go/pkg/operator/resource/* for core types (instead of our ./lib/resource* packages)
  • leave under ./lib just ./lib/*/machineconfig* files, types and funcs since we still need those till move types to openshift/api #588 is done
  • while removing funcs from the above, contribute any core func to library-go as well (if any, haven't checked).

Example:

Move

machine-config-operator/pkg/operator/sync.go

Line 80 in fcf5aa0

_, updated, err := resourceapply.ApplyCustomResourceDefinition(optr.apiExtClient.ApiextensionsV1beta1(), c)
to https://github.com/openshift/library-go/blob/master/pkg/operator/resource/resourceapply/apiextensions.go#L32 (applies for resourceread package and the others as well in the surrounding lines)
@runcom runcom added the jira label Jun 5, 2019
@LorbusChris LorbusChris self-assigned this Jun 5, 2019
@LorbusChris LorbusChris mentioned this issue Jun 6, 2019
Closed
@dustymabe dustymabe removed the jira label Sep 5, 2019
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2020
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 17, 2020
@LorbusChris
Copy link
Member

/remove-lifecycle rotten

@openshift-ci-robot openshift-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 19, 2020
@LorbusChris LorbusChris removed their assignment Nov 3, 2020
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2021
@LorbusChris
Copy link
Member

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 1, 2021
@mkenigs mkenigs mentioned this issue Nov 18, 2021
Merged
@mkenigs mkenigs mentioned this issue Dec 16, 2021
Closed
mkenigs added a commit to mkenigs/machine-config-operator that referenced this issue Jan 31, 2022
@mkenigs
Use library-go ApplyDeployment and ApplyDaemonset
e65917a 
Our current functions in ./lib are out of date and we should be using
library-go instead

The library-go functions require passing the generation of the
previously applied deployment/daemonset, and this should be stored on an
MCO CRD. Because this currently doesn't exist, the existing generation
is passed as generation. This is no worse than how MCO's current
functions work, so the library-go functions should still be used until
an MCO CRD is created.

Files with the now unused functions and unused helper functions were
removed:
resourceapply/apps.go
resourcemerge/{apps.go,apps_test.go,core.go,core_test.go}

Helps openshift#819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@runcom @openshift-bot @dustymabe @LorbusChris @openshift-ci-robot