Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Predefined PostProcessingFunction for Jurassic model #3559

Open
mingshl opened this issue Feb 15, 2025 · 0 comments
Open
Labels
enhancement New feature or request untriaged

Comments

@mingshl
Copy link
Collaborator

mingshl commented Feb 15, 2025

Is your feature request related to a problem?
Raised the concern from this PR #3553, we should set the default model interface when it's using the post processing function from the blueprint. If users define custom post processing function, we should not apply model interface and let users to define a custom model interface.

What solution would you like?
Need to add a predefine PostProcessingFunction for Jurassic model, similar to BedrockEmbeddingPostProcessFunction,

Then we should add the check for the name of post processing function, then apply the default interface for Jurassic model, we already had the similar logic in cohere embedding and bedrock embedding. We should do the same for Jurassic model.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@mingshl mingshl added enhancement New feature or request untriaged labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

1 participant