Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Validate Model Update/Delete When it's In Use #3528

Open
bzhangam opened this issue Feb 11, 2025 · 0 comments
Open

[FEATURE] Validate Model Update/Delete When it's In Use #3528

bzhangam opened this issue Feb 11, 2025 · 0 comments
Labels
enhancement New feature or request untriaged

Comments

@bzhangam
Copy link

Is your feature request related to a problem?
Currently, ML Commons allows updating or deleting models without validation, which can lead to the following issues:

  1. Deleting a model that is still in use, potentially breaking dependent processes.
  2. Updating critical model configurations (e.g., embedding_dimension for a dense model), which may cause incompatibility with existing index configurations or stored embeddings.

What solution would you like?
To prevent these issues, we need a mechanism that tracks which resources are using a model and enforces validation before updates or deletions.

Model Deletion Rules
Before deleting a model:

  1. Check if the model is currently in use.
  2. If the model is in use, ensure it is properly unregistered and no longer referenced before proceeding with deletion.

Model Update Rules
Before updating a model:

  1. Validate compatibility with existing usage.
  2. If the update is incompatible, either:
    • Adjust dependencies to maintain compatibility.
    • Stop using the model before applying the update.

What alternatives have you considered?
N/A

Do you have any additional context?
N/A

@bzhangam bzhangam added enhancement New feature or request untriaged labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

1 participant