Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling metrics #5431

Open
dlvenable opened this issue Feb 11, 2025 · 0 comments
Open

Allow disabling metrics #5431

dlvenable opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

Data Prepper produces a lot of metrics. And not all of them are necessary for all users. I'd like a way to disable metrics in Data Prepper.

Describe the solution you'd like

Add a list to the data-prepper-config.yaml file - disabled_metrics. This will disable metrics by name. It can also support Ant glob patterns to control how they are disabled.

disabled_metrics:
  - **.add_entries.recordsOut.count
  - jvm.gc.max.data.size.value
  - **.BlockingBuffer.readLatency.count

Describe alternatives you've considered (Optional)

I considered adding this into a new file. But, the metrics are all configured in data-prepper-config.yaml, so I think we should keep it there for consistency.

We could also have some heuristic to know when a metric is part of a pipeline or not. Then we could avoid the * and **. But, using * and ** would be more flexible. And probably clearer.

For example, this could attempt to determine that the metric is associated with a pipeline and then disable.

disabled_metrics:
  - add_entries.recordsOut.count

Additional context

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant