Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] upgrade to Node.js 20 #9466

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

[chore] upgrade to Node.js 20 #9466

wants to merge 37 commits into from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Feb 28, 2025

Description

Upgrading the Node.js version used from 18.x to the latest LTS version 20.x.

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 9466.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@kavilla kavilla added the nodejs 🍭 issues related to nodejs client label Feb 28, 2025
@kavilla
Copy link
Member Author

kavilla commented Feb 28, 2025

what to see how far the automation gets

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.96552% with 18 lines in your changes missing coverage. Please review.

Project coverage is 61.74%. Comparing base (673a512) to head (59f6c34).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../data_source_management/public/components/utils.ts 53.84% 5 Missing and 1 partial ⚠️
.../public/query/query_string/query_string_manager.ts 66.66% 2 Missing and 1 partial ⚠️
..._source_management/framework/utils/use_polling.tsx 33.33% 2 Missing ⚠️
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% 1 Missing ⚠️
...ckages/osd-opensearch-archiver/src/lib/progress.ts 0.00% 1 Missing ⚠️
packages/osd-optimizer/src/node/cache.ts 0.00% 1 Missing ⚠️
src/core/server/http/base_path_proxy_server.ts 0.00% 1 Missing ⚠️
src/core/server/metrics/metrics_service.ts 0.00% 1 Missing ⚠️
.../docker_generator/templates/dockerfile.template.ts 0.00% 1 Missing ⚠️
...query_string/language_service/lib/query_result.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9466      +/-   ##
==========================================
- Coverage   61.76%   61.74%   -0.02%     
==========================================
  Files        3815     3815              
  Lines       91890    91904      +14     
  Branches    14570    14572       +2     
==========================================
- Hits        56758    56750       -8     
- Misses      31474    31495      +21     
- Partials     3658     3659       +1
Flag Coverage Δ
Linux_1 28.97% <5.88%> (-0.01%) ⬇️
Linux_2 56.32% <50.00%> (-0.08%) ⬇️
Linux_3 39.30% <65.95%> (+<0.01%) ⬆️
Linux_4 28.86% <8.10%> (-0.01%) ⬇️
Windows_1 28.99% <5.88%> (-0.01%) ⬇️
Windows_2 56.27% <50.00%> (-0.08%) ⬇️
Windows_3 39.31% <65.95%> (+<0.01%) ⬆️
Windows_4 28.86% <8.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kavilla kavilla linked an issue Mar 1, 2025 that may be closed by this pull request
[Node.js v20] Plugin Verification Meta Issue #9459
Open
16 tasks
@kavilla kavilla mentioned this pull request Mar 4, 2025
Open
7 tasks
@peterzhuamazon peterzhuamazon mentioned this pull request Mar 4, 2025
Open
66 tasks
kavilla and others added 19 commits March 7, 2025 10:23
@kavilla
[chore] upgrade to Node LTS 20
28deef4 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
Upgrade APM node
7ec38e8 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
build with plugins workflow
a761629 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
add on push
9f9c86b 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
plugins
7635a92 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
dont run on image
1bcbd82 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
just use node for plugin_helpers
ed9f31e 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
unzip
5394d6a 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
unzip and then untar
ddd2556 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
create directory
bb0daf9 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
updates
9d7cb54 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
pwd
67c0688 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
resolve to newer browserify rsa to avoid deprecation warning,
b5a3d8b 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
ensure encoding on filesync and also no hyphen for utf8
d20b844 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
handle node issues
a0e84a4 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
build osd-pm
09f3510 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
to string utf8
3bc6a26 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
tostring utf8
a2dcf7f 
Signed-off-by: Kawika Avilla <[email protected]>
@nhtruong @kavilla
Upgrading opensearch client to 3.x (#9139)
b1ec19b
kavilla added 14 commits March 7, 2025 10:23
@kavilla
update dependencies
6f69ad5 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
dont expect error
fa90950 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
ignore hapi
32549d9 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
restore polyfill after slight downgrade of typescript
69a8f79 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
fix tests
1c91a03 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
fix yarn lock file
ebc5ffb 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update jest
e3daf8a 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
remove ts jest and add module resolver
2d343d0 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
restore tests
ab8c5f3 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
skip test for now
b9eacd5 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
fix caniuse
30b5c28 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
fix lock file
f04f152 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update workflow to run faster
1e778d9 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
skip test per suggestion
69d095a 
Signed-off-by: Kawika Avilla <[email protected]>
kavilla added 2 commits March 7, 2025 22:01
@kavilla
some optimizations
beb80bf 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
restore chromium
59f6c34 
Signed-off-by: Kawika Avilla <[email protected]>
kavilla added 2 commits March 8, 2025 00:03
@kavilla
fix regex
f3dc0e3 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
set limits for heap
1e9c400 
Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 will be requested when the pull request is marked ready for review angle943 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
distinguished-contributor failed changeset nodejs 🍭 issues related to nodejs client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Node.js v20] Plugin Verification Meta Issue
2 participants
@kavilla @nhtruong