Skip to content

Commit 0bafae5

Browse files
authored
Merge pull request #252 from edquist/SOFTWARE-4964.condor-blahp
allow blahp to be installed by dependency (SOFTWARE-4964)
2 parents 632b33c + bc8a255 commit 0bafae5

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

osgtest/tests/test_410_jobs.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def run_job_in_tmp_dir(self, command, message, verify_environment=True):
4242
shutil.rmtree(tmp_dir)
4343

4444
def test_01_condor_run_pbs(self):
45-
core.skip_ok_unless_installed('condor', 'blahp')
45+
core.skip_ok_unless_installed('condor')
46+
core.skip_ok_unless_installed('blahp', by_dependency=True)
4647
core.skip_ok_unless_installed('torque-mom', 'torque-server', 'torque-scheduler', by_dependency=True)
4748
self.skip_bad_unless(core.state['jobs.env-set'], 'job environment not set')
4849
self.skip_bad_unless(service.is_running('condor'), 'condor not running')
@@ -54,7 +55,10 @@ def test_01_condor_run_pbs(self):
5455
# Figure out whether the installed BLAHP package is the same as or later
5556
# than "blahp-1.18.11.bosco-4.osg*" (in the RPM sense), because it's the
5657
# first build in which the job environments are correctly passed to PBS.
57-
blahp_pbs_has_env_vars = core.PackageVersion('blahp') >= '1.18.11.bosco-4.osg'
58+
# The 'condor-blahp' rpm obsoletes 'blahp' in 9.5.0 (SOFTWARE-4964)
59+
blahp_pbs_has_env_vars = (
60+
core.rpm_is_installed('condor-blahp') or
61+
core.PackageVersion('blahp') >= '1.18.11.bosco-4.osg')
5862

5963
self.run_job_in_tmp_dir(command, 'condor_run a Condor job', verify_environment=blahp_pbs_has_env_vars)
6064

rpm/osg-test.spec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Summary: Tests an OSG Software installation
22
Name: osg-test
3-
Version: 3.2.0
3+
Version: 3.2.1
44
Release: 1%{?dist}
55
License: Apache License, 2.0
66
Group: Applications/Grid
@@ -45,6 +45,9 @@ make install DESTDIR=$RPM_BUILD_ROOT PYTHON=%{__python}
4545
%{_sbindir}/%{name}-log-viewer
4646

4747
%changelog
48+
* Thu Apr 14 2022 Carl Edquist <[email protected]> - 3.2.1-1
49+
- Allow condor-blahp rpm to be used in place of blahp (SOFTWARE-4964)
50+
4851
* Mon Aug 23 2021 Matyas Selmeci <[email protected]> - 3.2.0-1
4952
- Use Python 3 on EL7 too
5053

0 commit comments

Comments
 (0)