Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR GitHub Template #1520

Open
1 task
pascalwilbrink opened this issue May 7, 2024 · 0 comments
Open
1 task

Create a PR GitHub Template #1520

pascalwilbrink opened this issue May 7, 2024 · 0 comments
Labels

Comments

@pascalwilbrink
Copy link
Member

pascalwilbrink commented May 7, 2024

To make our life more simple, we can make use of a PR Template in GitHub

Example:

## Hi, i just made a pull request! 👏
<!-- Briefly tell us what this pull request is all about --> 
 
## Changes Made
<!-- What did you do? --> 
- [ ] Fixed some typos in the docs 📝 
- [ ] Added some cool new tests 🧪 
- [ ] Made the code less spaghetti-like 🍝 
- [ ] Squashed some pesky bugs 🐛 
- [ ] Sped things up a bit ⏱️ 
- [ ] Cleaned up the codebase a bit 🧹 
- [ ] Did some other stuff: 
    <!-- Fill in --> 
 
## Related Issue
<!-- Got an issue number for this? --> 
 
## Screenshots (if needed)
<!-- Any visuals to show off your changes? --> 
 
## Checklist
<!-- Make sure you've covered all the bases --> 
- [ ] Updated the docs 📖 
- [ ] Wrote some tests 🧪 
- [ ] Code looks good to go ✅ 
- [ ] Reviewed my own code 👀 
- [ ] Left comments where things might get hairy 💬 
- [ ] Updated the README if needed 📋 
- [ ] No new warnings or errors 🚫⚠️ 
- [ ] Tests pass with my changes ✅ 
- [ ] Checked for any sensitive info or oopsies 🤫 
- [ ] Gave it a spin on my local setup 🔧 
- [ ] All my commits are signed off ✍️ 
 
## Reviewers
<!-- Tag anyone specific who should take a look --> 
 
## Signed-off-by
<!-- Your John Hancock here -->

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

Acceptance criteria:

  • PR template exists in .github folder
@pascalwilbrink pascalwilbrink added the Kind: Enhancement New Request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant