Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor type plug-ins should be able to be rendered without a doc being present #1512

Open
pascalwilbrink opened this issue Apr 30, 2024 · 1 comment · May be fixed by #1530
Open

Editor type plug-ins should be able to be rendered without a doc being present #1512

pascalwilbrink opened this issue Apr 30, 2024 · 1 comment · May be fixed by #1530
Assignees
Labels
Kind: Enhancement New Request PR: Feedback Needed Status: Help wanted Extra attention is needed Status: Ready for development Checked by all co-developers

Comments

@pascalwilbrink
Copy link
Member

pascalwilbrink commented Apr 30, 2024

Currently only menu type plug-ins are supported to work without a doc being present.
This should also be the case for editor type plug-ins.

Acceptance criteria

  • requiredDoc attribute should not only be present in menu type plugins but also editor type ones
  • Editor type plugins should be able to be rendered without a doc being present.
    • From a given list of editor type plugins, only the ones with requiredDoc: false are visible when no doc is loaded and then if a doc is loaded all of them are visible.
  • If no editor type plugins are rendered, don't show the mwc-tab-bar (CSS :empty)
@pascalwilbrink pascalwilbrink added the Kind: Enhancement New Request label Apr 30, 2024
@pascalwilbrink pascalwilbrink self-assigned this Apr 30, 2024
@juancho0202 juancho0202 added the Status: Ready for development Checked by all co-developers label May 7, 2024
@juancho0202 juancho0202 linked a pull request May 16, 2024 that will close this issue
@juancho0202
Copy link
Contributor

After implementing this change in #1530, the tests for packages/openscd/test/unit/Plugging.test.ts stop working specifically at "add custom plugin dialog". The tests neither pass or fail just become unresponsive.

I noticed that this goes away after undoing the adding of requireDoc: true to all editor type plugins in packages/openscd/src/plugins.ts but this change is now required for all editor type plugins to tell apart the ones that should appear initially at the landing screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Enhancement New Request PR: Feedback Needed Status: Help wanted Extra attention is needed Status: Ready for development Checked by all co-developers
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants