Skip to content

Add "deployment" lines to Honeycomb traces for before/after comparison #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucyb opened this issue Nov 22, 2022 · 1 comment
Open

Comments

@lucyb
Copy link
Contributor

lucyb commented Nov 22, 2022

A recent incident with slow performing queries was caused by a regression in cohort extractor. It took a while to track down. In future, it would be helpful to be able to associate code changes with job performance/behaviour. Sending details of deployments into Honeycomb would give us this information.

@lucyb lucyb changed the title Add "deployment" lines to honeycomb traces for before/after comparison Add "deployment" lines to Honeycomb traces for before/after comparison Nov 22, 2022
@madwort
Copy link
Contributor

madwort commented Nov 23, 2022

Use markers.

For job-runner changes & cohort-extractor changes.
Problem: we don't have a formalised way of saying when a deploy happens.
Would be easier if we had docker-ised job-runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants