Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event detail page #56

Open
3 tasks
adborden opened this issue Nov 11, 2019 · 5 comments
Open
3 tasks

Event detail page #56

adborden opened this issue Nov 11, 2019 · 5 comments
Assignees
Milestone

Comments

@adborden
Copy link
Member

adborden commented Nov 11, 2019

As a user, I want a page that represents a single event, so that I can link, share, and bookmark the page where I can see all the details related to the event and how to attend, also allowing me to better find it in web search results.
We also want to link back from the description in the google calendar.

Acceptance criteria

  • /event/:id url exists for events
  • Event is only visible if published
  • Each event listed on the homepage link to the Event's page
@mikeubell
Copy link
Collaborator

I wonder why we need this as you can do all this via Google Calendar.

@adborden
Copy link
Member Author

Because Google calendar won't be able to do all the things we need it to do, like display the event in the language of the user.

@adborden adborden added this to the v2 milestone Nov 17, 2019
@adborden adborden changed the title Event page Event detail page Nov 17, 2019
@mikeubell
Copy link
Collaborator

Because Google calendar won't be able to do all the things we need it to do, like display the event in the language of the user.

Then why are we using Google Calendar at all? If we are going to recreate its functionality in the app, there seems little reason to export the events.

@mikeubell mikeubell modified the milestones: v2, Proposals Nov 17, 2019
@adborden
Copy link
Member Author

Why do you think the event detail page is recreating functionality from Google Calendar?

Here's how I'm thinking of it. By publishing to Google Calendar, we are gaining all the features of Google Calendar and then layering additional functionality on top. Any tool that integrates with Google Calendar, can essentially integrate with out application (although this is only partially true without more advanced integration).

For example, event approval. Google Calendar does not have a concept of creating "pending" events privately and then publishing them once approved. So that's a feature we layer on top. In order to show pending events to approvers, we need to show the full detail of the event. Even if we published pending events to a private Google Calendar, not all of those details are supported by Google Calendar, like languages.

We are walking a thin line about what features should be Google Calendar vs the application. We'll know more as we go but the event detail is a quick way to move forward without betting too much on Google Calendar, which would require some complex integration work. We'll get to more advanced integration with Google Calendar, but I don't think we want to spend time on it until we understand the workflow with ACCCC.

@mikeubell mikeubell modified the milestones: Proposals, v2 Nov 20, 2019
@mikeubell
Copy link
Collaborator

While I'm not sure I agree completely with your analysis. We already have the update page to show the full detail of the event to approvers, so I don't see the need for this feature to for that reason. I do think this may be a good solution for showing all the event details over #68. We can add a link to the event detail page in the Calendar description. That way the code will not need to be updated when detail fields are added/removed/changed.

@mikeubell mikeubell modified the milestones: v2, v1 Nov 29, 2019
@mikeubell mikeubell self-assigned this Nov 29, 2019
mikeubell added a commit that referenced this issue Dec 7, 2019
mikeubell added a commit that referenced this issue Dec 7, 2019
@mikeubell mikeubell moved this from Ready to In progress in Alameda County Census Events Dec 8, 2019
mikeubell added a commit that referenced this issue Dec 11, 2019
mikeubell added a commit that referenced this issue Dec 11, 2019
@mikeubell mikeubell moved this from In progress to Done in Alameda County Census Events Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants