-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move code specifying the location of Python source out of the .src (shell script) files. #27
Comments
That sounds like a good idea.
Howard
On January 17, 2020 at 9:29:50 PM, ttheimeroo ([email protected]) wrote:
The script file Scraper_full_json.sh contains a conditional statement to
set the location of Python for the host computer. This code is near line
22. There is similar code in Scraper_Twitter.sh.
Suggest to move this customization out of the code base and into a
configuration file. The config file would not be included in a Git pull. A
similar strategy would be to require that the host computer be set with an
environmental variable or PATH stmt. The latter solution would be described
in documentation. The goal is to ensure the the proper version of Python
will be found without modifying the project code base.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27?email_source=notifications&email_token=AA43EO3Y7NU2QA2MBFGNRCLQ6KHU3A5CNFSM4KIRFSIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHCUZJQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA43EO6J4ADABLTCLPRXK2LQ6KHU3ANCNFSM4KIRFSIA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The script file Scraper_full_json.sh contains a conditional statement to set the location of Python for the host computer. This code is near line 22. There is similar code in Scraper_Twitter.sh.
Suggest to move this customization out of the code base and into a configuration file. The config file would not be included in a Git pull. A similar strategy would be to require that the host computer be set with an environmental variable or PATH stmt. The latter solution would be described in documentation. The goal is to ensure the the proper version of Python will be found in any new environment without modifying the project code base.
The text was updated successfully, but these errors were encountered: