-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OA-40: Add property to control starting of the module #24
Conversation
api/src/main/java/org/openmrs/module/oauth2login/OAuth2LoginActivator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left 2 comments
Two high-level comments:
|
api/src/test/java/org/openmrs/module/oauth2login/OAuth2LoginActivatorTest.java
Outdated
Show resolved
Hide resolved
api/src/test/java/org/openmrs/module/oauth2login/OAuth2LoginActivatorTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nitpick comments, but this is approved to be merged
Thank you @ibacher for the insightful comments. Your comments makes sense to me. I will create a TRUNK ticket to further evaluate the possibility of incorporating this functionality into the core. |
Issue: https://openmrs.atlassian.net/browse/OA-40
This PR adds property
oauth2.enabled
to control starting of the module. It defaults totrue
to ensure backward compatibility if the property is not set.