diff --git a/api/pom.xml b/api/pom.xml index eab58555..c28626b7 100644 --- a/api/pom.xml +++ b/api/pom.xml @@ -15,7 +15,7 @@ org.openmrs.module legacyui - 1.8.2-SNAPSHOT + 1.8.3-SNAPSHOT legacyui-api diff --git a/omod/pom.xml b/omod/pom.xml index 60dff2e2..86dd15d3 100644 --- a/omod/pom.xml +++ b/omod/pom.xml @@ -15,7 +15,7 @@ org.openmrs.module legacyui - 1.8.2-SNAPSHOT + 1.8.3-SNAPSHOT legacyui-omod diff --git a/omod/src/main/java/org/openmrs/web/dwr/DWRProgramWorkflowService.java b/omod/src/main/java/org/openmrs/web/dwr/DWRProgramWorkflowService.java index be5bb85f..2391deef 100644 --- a/omod/src/main/java/org/openmrs/web/dwr/DWRProgramWorkflowService.java +++ b/omod/src/main/java/org/openmrs/web/dwr/DWRProgramWorkflowService.java @@ -269,10 +269,10 @@ public void changeToState(Integer patientProgramId, Integer programWorkflowId, I s.savePatientProgram(pp); } - public void voidLastState(Integer patientProgramId, String programWorkflowUuid, String voidReason) { + public void voidLastState(Integer patientProgramId, Integer programWorkflowId, String voidReason) { ProgramWorkflowService s = Context.getProgramWorkflowService(); PatientProgram pp = s.getPatientProgram(patientProgramId); - ProgramWorkflow wf = s.getWorkflowByUuid(programWorkflowUuid); + ProgramWorkflow wf = pp.getProgram().getWorkflow(programWorkflowId); pp.voidLastState(wf, Context.getAuthenticatedUser(), new Date(), voidReason); Context.getProgramWorkflowService().savePatientProgram(pp); } diff --git a/omod/src/main/webapp/admin/person/include/editPersonInfo.jsp b/omod/src/main/webapp/admin/person/include/editPersonInfo.jsp index b23b4c61..184e4169 100644 --- a/omod/src/main/webapp/admin/person/include/editPersonInfo.jsp +++ b/omod/src/main/webapp/admin/person/include/editPersonInfo.jsp @@ -210,11 +210,11 @@ - + - + diff --git a/omod/src/main/webapp/admin/person/personForm.jsp b/omod/src/main/webapp/admin/person/personForm.jsp index 0d869dd7..6e462e75 100644 --- a/omod/src/main/webapp/admin/person/personForm.jsp +++ b/omod/src/main/webapp/admin/person/personForm.jsp @@ -249,7 +249,7 @@
- - ${person.personVoidReason} + -
" />
diff --git a/omod/src/main/webapp/admin/users/localHeader.jsp b/omod/src/main/webapp/admin/users/localHeader.jsp index 88ff945f..5372d6b9 100644 --- a/omod/src/main/webapp/admin/users/localHeader.jsp +++ b/omod/src/main/webapp/admin/users/localHeader.jsp @@ -3,7 +3,7 @@ -
  • class="active"> +
  • class="active"> diff --git a/omod/src/main/webapp/admin/users/users.jsp b/omod/src/main/webapp/admin/users/users.jsp index 989a8465..46a2230b 100644 --- a/omod/src/main/webapp/admin/users/users.jsp +++ b/omod/src/main/webapp/admin/users/users.jsp @@ -90,7 +90,7 @@ - + @@ -102,14 +102,14 @@ - ${inheritedRole} -> + -> - ${r} + - , ${r} + , diff --git a/omod/src/main/webapp/resources/scripts/dojo/src/widget/openmrs/OpenmrsSearch.js b/omod/src/main/webapp/resources/scripts/dojo/src/widget/openmrs/OpenmrsSearch.js index a44f817c..277e6331 100644 --- a/omod/src/main/webapp/resources/scripts/dojo/src/widget/openmrs/OpenmrsSearch.js +++ b/omod/src/main/webapp/resources/scripts/dojo/src/widget/openmrs/OpenmrsSearch.js @@ -765,10 +765,11 @@ dojo.widget.defineWidget( lastItemDisplayed = this.objectsFound.length; } - this.infoBar.innerHTML = ''; - if (this.lastPhraseSearched != null) - this.infoBar.innerHTML = '   ' + omsgs.resultsFor + ' "' + this.lastPhraseSearched + '".  '; - + if (this.lastPhraseSearched != null) { + resultsText = omsgs.resultsFor + ' "' + this.lastPhraseSearched + '".'; + this.infoBar.innerHTML = $j('
    ').text(resultsText).html(); + } + if (this.objectsFound.length > 0) this.infoBar.innerHTML += omsgs.searchResultsViewing + " " + this.firstItemDisplayed + "-" + lastItemDisplayed + " " + omsgs.searchResultsOf + " " + total + "   "; diff --git a/omod/src/test/java/org/openmrs/web/dwr/DWRProgramWorkflowServiceTest.java b/omod/src/test/java/org/openmrs/web/dwr/DWRProgramWorkflowServiceTest.java index 2d160393..e67d9651 100644 --- a/omod/src/test/java/org/openmrs/web/dwr/DWRProgramWorkflowServiceTest.java +++ b/omod/src/test/java/org/openmrs/web/dwr/DWRProgramWorkflowServiceTest.java @@ -13,6 +13,7 @@ import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; import java.util.Set; import java.util.Vector; @@ -22,6 +23,7 @@ import org.openmrs.Concept; import org.openmrs.ConceptName; import org.openmrs.PatientProgram; +import org.openmrs.PatientState; import org.openmrs.ProgramWorkflow; import org.openmrs.ProgramWorkflowState; import org.openmrs.api.context.Context; @@ -160,4 +162,22 @@ public void getProgramByName_shouldReturnNullWhenThereIsNoProgramWorkflowForGive assertNull(workflow); } + @Test + @Verifies(value = "last state should be voided", method = "voidLastState") + public void voidLastState_shouldVoidTheLastState() throws Exception { + executeDataSet(PROGRAM_NEXT_STATES_XML); + + Integer programId = 11; + Integer workflowId = 501; + String voidReason = "Remove it"; + String patientStateUuid = "e2d62091-7b57-11eb-b6f7-0242c0a82003"; + + PatientState patientState = Context.getProgramWorkflowService().getPatientStateByUuid(patientStateUuid); + + assertFalse(patientState.getVoided()); + + dwrProgramWorkflowService.voidLastState(programId, workflowId, voidReason); + patientState = Context.getProgramWorkflowService().getPatientStateByUuid(patientStateUuid); + assertTrue(patientState.getVoided()); + } } diff --git a/omod/src/test/resources/org/openmrs/web/dwr/include/DWRProgramWorkflowServiceTest-initialStates.xml b/omod/src/test/resources/org/openmrs/web/dwr/include/DWRProgramWorkflowServiceTest-initialStates.xml index e5ee82b6..ed5ca8ce 100644 --- a/omod/src/test/resources/org/openmrs/web/dwr/include/DWRProgramWorkflowServiceTest-initialStates.xml +++ b/omod/src/test/resources/org/openmrs/web/dwr/include/DWRProgramWorkflowServiceTest-initialStates.xml @@ -31,15 +31,16 @@ - + - - - - - + + + + + + diff --git a/pom.xml b/pom.xml index 8d53a048..932796ab 100644 --- a/pom.xml +++ b/pom.xml @@ -21,7 +21,7 @@ org.openmrs.module legacyui - 1.8.2-SNAPSHOT + 1.8.3-SNAPSHOT pom Legacy UI Module Provides the legacy UI which was removed from the platform since version 2.0