Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests when cross compiling #1574

Open
franziskuskiefer opened this issue May 7, 2024 · 2 comments
Open

Improve tests when cross compiling #1574

franziskuskiefer opened this issue May 7, 2024 · 2 comments
Labels

Comments

@franziskuskiefer
Copy link
Contributor

With #1573 we enable more tests for all provider implementations.
Unfortunately, when cross compiling the test proc macro picks up the supported ciphersuites of the host, not the target. Since proc macros are built for the host, there's no easy way around it. For now the tests of unsupported ciphersuites simple return without doing anything (thus pass).
This works but is not great for visibility in what's being tested. This issue tracks improving this.

@keks
Copy link
Contributor

keks commented Jun 24, 2024

@franziskuskiefer do you think this blocks v0.6?

@franziskuskiefer
Copy link
Contributor Author

I don't think this should block 0.6. But let's assess what exactly we want to do here and describe it. Or close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants