You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OpenmlConnector:
Almost all methods starts with openMl. This is generally not recommended as it should be clear from the object type itself what it is upload.
It would be like class person would have methods like getPersonName.
Method also usually start with nout and then verb.
e.g. dataUpload. This could lead to thinking that you are creating some sort of precooked dataupload object (especially when the return data type is called DataUpload).
It is usually recommended to start with verb first, e.g. uploadData.
It would be also consistent with some other methods in the class that starts with verb.
OpenmlConnector:
Almost all methods starts with openMl. This is generally not recommended as it should be clear from the object type itself what it is upload.
It would be like class person would have methods like getPersonName.
Method also usually start with nout and then verb.
e.g. dataUpload. This could lead to thinking that you are creating some sort of precooked dataupload object (especially when the return data type is called DataUpload).
It is usually recommended to start with verb first, e.g. uploadData.
It would be also consistent with some other methods in the class that starts with verb.
There are multiple ways to go, we could break the API or we could stuill support the old api and mark the old methods as obsolete.
Ref: http://www.iwombat.com/standards/JavaStyleGuide.html
The text was updated successfully, but these errors were encountered: