hetu core clean code

Signed-off-by: chenpingzeng <[email protected]>

Author: chenpingzeng

hetu-hive-functions/src/main/java/io/hetu/core/hive/dynamicfunctions/utils/HiveTypeTranslator.java

@@ -197,7 +197,7 @@ private static TypeInfo limitedDepthTranslateToHiveTypeInfo(Type type, int maxDe
             if (charLength <= HiveChar.MAX_CHAR_LENGTH) {
                 return getCharTypeInfo(charLength);
             }
-            throw new PrestoException(NOT_SUPPORTED, String.format("Unsupported Hive type: %s." +
+            throw new PrestoException(NOT_SUPPORTED, String.format(Locale.ROOT, "Unsupported Hive type: %s." +
                             " Supported CHAR types: CHAR(<=%d).",
                     type, HiveChar.MAX_CHAR_LENGTH));
         }

presto-main/src/main/java/io/prestosql/dispatcher/DispatchManager.java

@@ -296,7 +296,7 @@ private boolean queryCreated(DispatchQuery dispatchQuery)
                     }
                     else {
                         if (!isUiQuery && dispatchQuery.getBasicQueryInfo().getState() == QueryState.FAILED) {
-                            QueryInfo queryInfo = queryHistoryService.toFullQueryInfo(dispatchQuery);
+                            QueryInfo queryInfo = QueryHistoryService.toFullQueryInfo(dispatchQuery);
                             queryHistoryService.insert(queryInfo);
                         }
                         // execution MUST be added to the expiration queue or there will be a leak

presto-main/src/main/java/io/prestosql/failuredetector/AbstractFailureRetryPolicy.java

@@ -28,10 +28,12 @@ public AbstractFailureRetryPolicy(IBackoff backoff)
         this.backoff = backoff;
     }
 
+    @Override
     public IBackoff getBackoff()
     {
         return this.backoff;
     }
 
+    @Override
     public abstract boolean hasFailed(HostAddress address);
 }

presto-main/src/main/java/io/prestosql/operator/scalar/RowToRowCast.java

@@ -42,6 +42,7 @@
 import io.prestosql.sql.gen.CallSiteBinder;
 
 import java.lang.invoke.MethodHandle;
+import java.nio.charset.StandardCharsets;
 import java.util.List;
 
 import static com.google.common.base.Preconditions.checkArgument;
@@ -102,7 +103,7 @@ private static Class<?> generateRowCast(Type fromType, Type toType, FunctionAndT
 
         // Embed the MD5 hash code of input and output types into the generated class name instead of the raw type names,
         // which could prevent the class name from hitting the length limitation and invalid characters.
-        byte[] md5Suffix = Hashing.md5().hashBytes((fromType + "$" + toType).getBytes()).asBytes();
+        byte[] md5Suffix = Hashing.md5().hashBytes((fromType + "$" + toType).getBytes(StandardCharsets.UTF_8)).asBytes();
 
         ClassDefinition definition = new ClassDefinition(
                 a(PUBLIC, FINAL),

presto-main/src/main/java/io/prestosql/server/remotetask/Backoff.java

@@ -72,11 +72,13 @@ public Backoff(int minTries, Duration maxFailureInterval, Ticker ticker, List<Du
                 .toArray();
     }
 
+    @Override
     public synchronized long getFailureCount()
     {
         return failureCount;
     }
 
+    @Override
     public synchronized Duration getFailureDuration()
     {
         if (firstFailureTime == 0) {
@@ -86,16 +88,19 @@ public synchronized Duration getFailureDuration()
         return new Duration(value, NANOSECONDS);
     }
 
+    @Override
     public synchronized Duration getFailureRequestTimeTotal()
     {
         return new Duration(max(0, failureRequestTimeTotal), NANOSECONDS);
     }
 
+    @Override
     public synchronized void startRequest()
     {
         lastRequestStart = ticker.read();
     }
 
+    @Override
     public synchronized void success()
     {
         lastRequestStart = 0;
@@ -118,6 +123,7 @@ protected synchronized void updateFailureCount()
      * @return true if the failure is considered permanent
      * min retried and maxErrorDuration is passed.
      */
+    @Override
     public synchronized boolean failure()
     {
         long now = ticker.read();
@@ -143,6 +149,7 @@ public synchronized boolean failure()
         return failureDuration >= maxFailureIntervalNanos;
     }
 
+    @Override
     public synchronized long getBackoffDelayNanos()
     {
         int tmpFailureCount = (int) min(backoffDelayIntervalsNanos.length, getFailureCount());

presto-main/src/main/java/io/prestosql/spiller/GenericPartitioningSpiller.java

@@ -267,6 +267,7 @@ private synchronized SingleStreamSpiller getSpiller(int partition)
         return spiller.get();
     }
 
+    @Override
     public Set<Integer> getSpilledPartitions()
     {
         return spilledPartitions;

presto-redis/src/main/java/io/prestosql/plugin/redis/RedisMetadata.java

@@ -120,6 +120,7 @@ public RedisTableHandle getTableHandle(final ConnectorSession session, final Sch
                 keyName);
     }
 
+    @Override
     public ConnectorTableMetadata getTableMetadata(final ConnectorSession session, final ConnectorTableHandle tableHandle)
     {
         SchemaTableName schemaTableName = ((RedisTableHandle) tableHandle).toSchemaTableName();
@@ -217,6 +218,7 @@ public ColumnMetadata getColumnMetadata(final ConnectorSession session, final Co
         return ((RedisColumnHandle) columnHandle).getColumnMetadata();
     }
 
+    @Override
     public boolean usesLegacyTableLayouts()
     {
         return false;

presto-redis/src/main/java/io/prestosql/plugin/redis/record/RedisRecordSetProvider.java

@@ -54,6 +54,7 @@ public RedisRecordSetProvider(
         this.jedisManager = requireNonNull(jedisManager, "jedisManager is null");
     }
 
+    @Override
     public RecordSet getRecordSet(
             final ConnectorTransactionHandle transaction,
             final ConnectorSession session,

presto-spi/src/main/java/io/prestosql/spi/function/BuiltInScalarFunctionImplementation.java

@@ -75,6 +75,7 @@ public BuiltInScalarFunctionImplementation(List<ScalarImplementationChoice> choi
         this.choices = ImmutableList.copyOf(choices);
     }
 
+    @Override
     public boolean isNullable()
     {
         return choices.get(0).isNullable();
@@ -85,6 +86,7 @@ public ArgumentProperty getArgumentProperty(int argumentIndex)
         return choices.get(0).argumentProperties.get(argumentIndex);
     }
 
+    @Override
     public MethodHandle getMethodHandle()
     {
         return choices.get(0).methodHandle;

presto-spi/src/test/java/io/prestosql/spi/block/VariableWidthBlockTest.java

@@ -88,7 +88,7 @@ private BloomFilter getBf(int size)
 
         BloomFilter bf = new BloomFilter(size, 0.01);
         for (int i = 0; i < 100; i++) {
-            bf.test(("value" + rnd.nextLong()).getBytes());
+            bf.test(("value" + rnd.nextLong()).getBytes(StandardCharsets.UTF_8));
         }
         return bf;
     }