Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field width configuration not functional #4582

Open
S-Haime opened this issue Jan 15, 2025 · 1 comment
Open

Field width configuration not functional #4582

S-Haime opened this issue Jan 15, 2025 · 1 comment
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. priority-high High priority size XS Extra small

Comments

@S-Haime
Copy link
Member

S-Haime commented Jan 15, 2025

Describe the bug
Whilst 'width' can be configured for custom review forms, it does not actually change the width and all fields display as full width. This presumably will also be the case for custom submission fields. This has been tested with various field types; text-types (as they are large by default and that might have explained it, but alas), checkboxes (small, but have the Name-field bug (#4581), but alas) and select / upload (small and no known bugs, but alas). The problem does however persist, both for 1/3 and 1/2 width.

For examples, see:

https://www.openlibhums.org/doctest/review/requests/22158/?access_code=a9d0606c-f164-48f4-bc6e-970318fa7e1e
https://www.openlibhums.org/doctest/review/requests/22159/?access_code=39793246-5fb2-45cb-b059-d9d0a889f641
https://www.openlibhums.org/doctest/review/requests/22041/?access_code=825560cc-6c61-4c08-ae05-e8c197049159

Janeway version
1.7

Additional context
I suggest removing the width configuration option rather than fixing it. I do not recall ever seeing it used (and if it is, it being dysfunctional does not seem to bother anyone). Especially as it is a largely aesthetical configuration option that is non-essential. (If anything, it probably increases the chance of a field being missed by accident, if they are 1/3 or 1/2 width.)

@S-Haime S-Haime added the bug Something's not working label Jan 15, 2025
@ajrbyers ajrbyers added size XS Extra small dev-ready This issue has been refined and is ready for development. priority-high High priority labels Jan 15, 2025
@ajrbyers
Copy link
Member

Agreed - this should just be removed. Moved to dev-ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working dev-ready This issue has been refined and is ready for development. priority-high High priority size XS Extra small
Projects
None yet
Development

No branches or pull requests

2 participants