Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile update banner will not dismiss #368

Open
StephDriver opened this issue Apr 26, 2024 · 4 comments
Open

Profile update banner will not dismiss #368

StephDriver opened this issue Apr 26, 2024 · 4 comments
Labels
bug Something isn't working high priority size XS

Comments

@StephDriver
Copy link
Contributor

StephDriver commented Apr 26, 2024

image

On updating twitter handle on my profile, and clicking to update profile, the screen moved to the banner, which then wouldn't dismiss (i.e. clicking the cross had no action).

When it eventually did dismiss, it logged me out and took me to a log in screen, and sent me an email stating that I had "requested my email address be updated" when all I'd changed was the twitter handle.

@StephDriver StephDriver added the bug Something isn't working label Apr 26, 2024
@StephDriver
Copy link
Contributor Author

<button type="button" id="close-profile-updated" class="right-6 inset-y-0 p-2">
    <img class="w-6 cursor-pointer" 
              src="/static/hourglass/media/icons/close-dark.svg" 
              alt="Close message">
</button>

@joemull
Copy link
Member

joemull commented Apr 29, 2024

Thanks for reporting this. I am able to reproduce the first part (not being able to dismiss the bubble by clicking on the X). I think it is a bug and can be handled together with #354.

As for the second part:

When it eventually did dismiss, it logged me out and took me to a log in screen, and sent me an email stating that I had "requested my email address be updated" when all I'd changed was the twitter handle.

It sounds like the "Update Email Address" button got pressed while in the course of trying to dismiss the "Profile updated" notification. They are somewhat close together on the page. Does that sound plausible? I can't think of another way this could have happened.

@StephDriver
Copy link
Contributor Author

@joemull

It sounds like the "Update Email Address" button got pressed while in the course of trying to dismiss the "Profile updated" notification. They are somewhat close together on the page. Does that sound plausible? I can't think of another way this could have happened.

I think that must have happened - as I then got an email stating that I'd changed my email address and I couldn't get back in at all until I'd confirmed the email was mine. Which does raise the question of whether we are / should be checking the email has actually changed between updates even if that button is pressed? But a trivial issue.

@joemull
Copy link
Member

joemull commented May 17, 2024

Yes we should check that to help prevent user mistakes. Might be worth raising a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority size XS
Projects
None yet
Development

No branches or pull requests

2 participants