Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles ask for Twitter handle rather than X #367

Open
StephDriver opened this issue Apr 26, 2024 · 2 comments
Open

profiles ask for Twitter handle rather than X #367

StephDriver opened this issue Apr 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@StephDriver
Copy link
Contributor

profiles still ask for Twitter handle, but main pages have been updated to X.

image

https://www.openlibhums.org/profile/

@StephDriver StephDriver added the bug Something isn't working label Apr 26, 2024
@joemull
Copy link
Member

joemull commented May 29, 2024

@StephDriver this comes from a model definition in core Janeway:

https://github.com/BirkbeckCTP/janeway/blob/a0a87f5cc99c5fe2fb43c21af1f3c55b324b9ae6/src/core/models.py#L253

But rather than change just this one field I think we should implement a generic social media link field.

@joemull
Copy link
Member

joemull commented Oct 3, 2024

Blocked until Janeway can flexibly handle different social media links and labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants