[REVIEW]: volesti: A C++ library for sampling and volume computation on convex bodies

[editorialbot]

Submitting author: @vissarion (Vissarion Fisikopoulos)
Repository: https://github.com/GeomScale/volesti
Branch with paper.md (empty if default branch): joss_paper
Version: v1.0.0
Editor: @olexandr-konovalov
Reviewers: @bsun1220, @pregnault
Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/906e2fddb2c3b979d10cafc65f0b76b1"><img src="https://joss.theoj.org/papers/906e2fddb2c3b979d10cafc65f0b76b1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/906e2fddb2c3b979d10cafc65f0b76b1/status.svg)](https://joss.theoj.org/papers/906e2fddb2c3b979d10cafc65f0b76b1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@bsun1220 & @pregnault, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @olexandr-konovalov know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@bsun1220, please create your checklist typing: @editorialbot generate my checklist

@pregnault, please create your checklist typing: @editorialbot generate my checklist

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.98  T=0.49 s (1016.1 files/s, 443640.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Text                            17              1              0          94982
C/C++ Header                   327          18117          14441          59151
C++                             76           3143           2389          14298
Objective-C++                    6              0              0           5386
CMake                           26            680            203           1826
Markdown                        30            587              0           1603
TeX                              1             37              0            338
Python                           8             93             82            303
YAML                             4              8             46             57
JSON                             2              1              0             28
make                             1              5              0             10
reStructuredText                 1             12             26              6
-------------------------------------------------------------------------------
SUM:                           499          22684          17187         177988
-------------------------------------------------------------------------------

Commit count by author:

   194	Vissarion Fisikopoulos
   182	tolischal
   165	Tolis
    38	Tolis Chalkis
    21	Vaibhav Thakkar
    14	vfisikop
    10	Ioannis Emiris
     9	pedrozudo
     7	AlexManochis
     6	Marios Papachristou
     6	Panagiotis Repouskos
     5	hariszaf
     4	Apostolos Chalkis
     4	Zafeirakis Zafeirakopoulos
     3	Suraj Choubey
     3	TolisChal
     3	dymil
     3	iakoviid
     2	Elias Tsigaridas
     2	dependabot[bot]
     2	zhanggiene
     1	Bento Natura
     1	Gabriele Masina
     1	Huu Phuoc Le
     1	Kostas-Pallikaris
     1	KunalKatiyar
     1	Pedro
     1	Pradumna Saraf
     1	Sharat-Bhat
     1	Soumya Tarafder
     1	vfdev

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 883

✅ The paper includes a Statement of need section

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.32614/RJ-2021-077 is OK
- 10.1101/2023.06.18.545486 is OK
- 10.1137/0909028 is OK
- 10.2307/1390681 is OK
- 10.1007/978-3-642-01689-9 is OK
- 10.1074/jbc.r800048200 is OK
- 10.1016/j.epsr.2020.106614 is OK
- 10.1137/0217060 is OK
- 10.1145/3188745.3188774 is OK
- 10.1109/focs.2019.00082 is OK
- 10.1145/1007352.1007403 is OK
- 10.1145/3194656 is OK
- 10.1007/s12532-015-0097-z is OK
- 10.1145/3584182 is OK
- 10.1007/BF01100204 is OK
- 10.1016/j.artint.2024.104067 is OK
- 10.1145/3589505 is OK
- 10.1016/j.laa.2022.04.002 is OK
- 10.4230/LIPICS.SOCG.2021.21 is OK
- 10.1016/j.comgeo.2022.101916 is OK
- 10.2139/ssrn.4744249 is OK
- 10.1137/1.9781611976472.15 is OK
- 10.3934/fods.2022018 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Fast MCMC Sampling Algorithms on Polytopes
- No DOI given, and none found for title: Eigen v3
- No DOI given, and none found for title: Intel Math Kernel Library (Intel MKL)
- No DOI given, and none found for title: Lectures on polytopes
- No DOI given, and none found for title: Sampling with Riemannian Hamiltonian Monte Carlo i...
- No DOI given, and none found for title: Randomized geometric tools for anomaly detection i...
- No DOI given, and none found for title: Hybrid Resource-Bound Analyses of Programs

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

License info:

🟡 License found: GNU Lesser General Public License v3.0 (Check here for OSI approval)

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈