Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: dageo: Data Assimilation in Geosciences #7879

Open
editorialbot opened this issue Mar 6, 2025 · 14 comments
Open

[PRE REVIEW]: dageo: Data Assimilation in Geosciences #7879

editorialbot opened this issue Mar 6, 2025 · 14 comments
Labels
Makefile pre-review Python query-scope Submissions of uncertain scope for JOSS Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @prisae (Dieter Werthmüller)
Repository: https://github.com/tuda-geo/dageo
Branch with paper.md (empty if default branch): joss
Version: v1.1.1
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/709b6bc25eaeabcb1ed4139c177875b8"><img src="https://joss.theoj.org/papers/709b6bc25eaeabcb1ed4139c177875b8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/709b6bc25eaeabcb1ed4139c177875b8/status.svg)](https://joss.theoj.org/papers/709b6bc25eaeabcb1ed4139c177875b8)

Author instructions

Thanks for submitting your paper to JOSS @prisae. Currently, there isn't a JOSS editor assigned to your paper.

@prisae if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Mar 6, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cageo.2012.03.011 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.21105/joss.06737 is OK
- 10.5281/zenodo.7425670 is OK
- 10.1175/1520-0493(1998)126<1719:ASITEK>2.0.CO;2 is OK
- 10.1016/j.gete.2024.100618 is OK
- 10.1016/j.ijggc.2024.104190 is OK
- 10.1007/978-3-030-96709-3 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (1305.2 files/s, 141930.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          13            562           1189           1057
YAML                             3             30             34            166
reStructuredText                12             96             89            135
TeX                              1              8              0            123
Markdown                         1             18              0            109
TOML                             1              8              0             71
make                             2             15              4             56
CSS                              1              5              9             19
Text                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            35            742           1325           1739
-------------------------------------------------------------------------------

Commit count by author:

    21	Dieter Werthmüller
     5	gabrielserrao
     1	Dieter Werthmuller
     1	Gabriel Serrao Seabra

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 813

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

OpenTerrace: A fast, flexible and extendable Python framework for thermal energy storage packed bed simulations
Submitting author: @jakobhaervig
Handling editor: @AdamRJensen (Active)
Reviewers: @baperry2, @AdamRJensen
Similarity score: 0.7546

PyNumDiff: A Python package for numerical differentiation of noisy time-series data
Submitting author: @florisvb
Handling editor: @christinahedges (Retired)
Reviewers: @pmli, @billtubbs
Similarity score: 0.7543

DataAssimilationBenchmarks.jl: a data assimilation research framework.
Submitting author: @cgrudz
Handling editor: @diehlpk (Active)
Reviewers: @peanutfun, @tmigot
Similarity score: 0.7521

diyepw: A Python package for Do-It-Yourself EnergyPlus weather file generation
Submitting author: @amandadsmith
Handling editor: @timtroendle (Retired)
Reviewers: @samuelduchesne, @fneum
Similarity score: 0.7490

OceanSpy: A Python package to facilitate ocean model data analysis and visualization
Submitting author: @malmans2
Handling editor: @kthyng (Active)
Reviewers: @tomchor, @platipodium
Similarity score: 0.7404

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Mar 6, 2025

Hi @prisae — I'm going to run a scope query on this because it is borderline in terms of size by lines of code. This will take a few weeks, thanks for your patience.

@kthyng
Copy link

kthyng commented Mar 6, 2025

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Mar 6, 2025
@prisae
Copy link

prisae commented Mar 7, 2025

Hi @kthyng - that is alright. In our experience, the method is theoretically very simple and straightforward, but practical implementation shows many hurdles that people struggle with. This is something we realized with students and also in training workshops. Therefore we thought it to be worthwhile and useful to the community to make a package out of it. But of course, the decision is up to the editorial board! Thanks!

@prisae
Copy link

prisae commented Mar 7, 2025

From the list of reviewers the one appearing when searching for "data assimilation" will be good candidates: timothyas, peanutfun, kwinkunks, haakon-e.

@prisae
Copy link

prisae commented Mar 7, 2025

I hope it is OK if I tag here my co-authors, so that they are kept in the loop: @gabrielserrao, @femkevossepoel

@gabrielserrao
Copy link

gabrielserrao commented Mar 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Makefile pre-review Python query-scope Submissions of uncertain scope for JOSS Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

4 participants