Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: STRAUSS: Sonification Tools & Resources for Analysis Using Sound Synthesis #7875

Open
editorialbot opened this issue Mar 5, 2025 · 7 comments
Assignees
Labels
AAS Papers being published together with a AAS submission review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @james-trayford (J. W. Trayford)
Repository: https://github.com/james-trayford/strauss
Branch with paper.md (empty if default branch): v1.0.0
Version: v1.0.0
Editor: @xuanxu
Reviewers: @manwithfeathers, @johicasado
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/07efb2a457d00bda7e9e7a7f98d0c64f"><img src="https://joss.theoj.org/papers/07efb2a457d00bda7e9e7a7f98d0c64f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/07efb2a457d00bda7e9e7a7f98d0c64f/status.svg)](https://joss.theoj.org/papers/07efb2a457d00bda7e9e7a7f98d0c64f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@manwithfeathers & @johicasado, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @xuanxu know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@manwithfeathers, please create your checklist typing: @editorialbot generate my checklist

@johicasado, please create your checklist typing: @editorialbot generate my checklist

@editorialbot editorialbot added AAS Papers being published together with a AAS submission review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Mar 5, 2025
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.08 s (1033.1 files/s, 372500.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Text                             6              2              0          12239
CSV                              3              0              0           6346
Python                          25            871           1744           2225
Jupyter Notebook                17              0           3919           1263
YAML                            15            121            149           1045
reStructuredText                 8            169             89            223
TeX                              1             19              0            205
Markdown                         2             54              0            166
Bourne Shell                     3             11             20             37
DOS Batch                        1              8              1             26
TOML                             1              0              0             17
CSS                              1              3              0             11
make                             1              4              7              9
HTML                             1              0              0              4
JavaScript                       1              0              0              3
-------------------------------------------------------------------------------
SUM:                            86           1262           5929          23819
-------------------------------------------------------------------------------

Commit count by author:

   328	James Trayford
    30	SamYoules
    11	Rose Shepherd
    10	james
     9	Samantha Youles
     1	James
     1	soleyhyman

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1244

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@xuanxu
Copy link
Member

xuanxu commented Mar 5, 2025

@johicasado, @manwithfeathers – This is the review thread for the paper. All of our communications will happen here from now on.

Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:

@editorialbot generate my checklist

As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/7875 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.3389/fpsyg.2022.1020102 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41550-021-01582-y is OK
- 10.1093/rasti/rzad021 is OK
- 10.21785/icad2023.1978 is OK
- 10.21105/joss.05819 is OK
- 10.5281/zenodo.7713214 is OK
- 10.21105/joss.03021 is OK
- 10.1088/0067-0049/192/1/9 is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1038/s41550-022-01721-z is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Gaps in Globular Cluster Streams: Pal 5 and the Ga...
- No DOI given, and none found for title: Data sonification archive
- No DOI given, and none found for title: Ear to the Sky: Astronomical Sonification for Acce...
- No DOI given, and none found for title: Collaborative data science
- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: Fidgit: An ungodly union of GitHub and Figshare

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAS Papers being published together with a AAS submission review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

2 participants