Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: galsbi: A Python package for the GalSBI galaxy population model #7718

Open
editorialbot opened this issue Jan 25, 2025 · 12 comments
Labels
pre-review PureBasic Python query-scope Submissions of uncertain scope for JOSS TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @silvanfischbacher (Silvan Fischbacher)
Repository: https://gitlab.com/cosmology-ethz/galsbi
Branch with paper.md (empty if default branch):
Version: 0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9edacb6707e48894a8385019734c719d"><img src="https://joss.theoj.org/papers/9edacb6707e48894a8385019734c719d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9edacb6707e48894a8385019734c719d/status.svg)](https://joss.theoj.org/papers/9edacb6707e48894a8385019734c719d)

Author instructions

Thanks for submitting your paper to JOSS @silvanfischbacher. Currently, there isn't a JOSS editor assigned to your paper.

@silvanfischbacher if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jan 25, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Adam Amara, perhaps the affiliations index need quoting?.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.ascom.2013.01.001 is OK
- 10.48550/arXiv.2412.08716 is OK
- 10.48550/arXiv.2412.08701 is OK
- 10.1088/1475-7516/2017/08/035 is OK
- 10.1088/1475-7516/2018/07/054 is OK
- 10.1088/1475-7516/2020/09/048 is OK
- 10.1088/1475-7516/2021/12/013 is OK
- 10.1103/PhysRevD.101.082003 is OK
- 10.1088/1475-7516/2024/05/049 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.21105/joss.01298 is OK
- 10.1051/aas:1996164 is OK
- 10.1086/510127 is OK
- 10.1016/j.ascom.2018.08.001 is OK
- 10.1016/j.ascom.2022.100603 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1088/1475-7516/2023/01/033 is OK
- 10.1103/PhysRevX.12.031029 is OK
- 10.1073/pnas.1912789117 is OK
- 10.1088/1475-7516/2018/11/015 is OK
- 10.1088/1475-7516/2020/06/050 is OK
- 10.1088/1475-7516/2024/04/023 is OK
- 10.3847/0004-637X/817/1/25 is OK
- 10.1088/1475-7516/2018/08/007 is OK
- 10.1088/0004-637X/801/2/73 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python
- No DOI given, and none found for title: Collaborative data science
- No DOI given, and none found for title: GalSBI: Galaxy population model with SPS

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1016/j.ascom.2021.100484 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.13 s (986.9 files/s, 306947.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
ReScript                        26              0              0          15759
SVG                              2              0             40           8653
Python                          60           1564           1765           6119
Text                             3              0              0           3008
reStructuredText                27            465            628            713
TeX                              1              3              0            479
Markdown                         2             51              0            233
Jupyter Notebook                 2              0            875            217
make                             2             33              6            158
YAML                             3             15              1            112
TOML                             1             15              5             82
Bourne Shell                     2              1              0             47
Dockerfile                       1              2              0              4
-------------------------------------------------------------------------------
SUM:                           132           2149           3320          35584
-------------------------------------------------------------------------------

Commit count by author:

    44	Silvan Fischbacher
    24	Uwe Schmitt
     2	root

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1827

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@silvanfischbacher
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

pysersic: A Python package for determining galaxy structural properties via Bayesian inference, accelerated with jax
Submitting author: @prappleizer
Handling editor: @eloisabentivegna (Retired)
Reviewers: @AstroBarker, @JBorrow
Similarity score: 0.6998

swift-emulator: A Python package for emulation of simulated scaling relations
Submitting author: @Moyoxkit
Handling editor: @dfm (Active)
Reviewers: @JDonaldM, @kstoreyf
Similarity score: 0.6969

21cmFAST v3: A Python-integrated C code for generating 3D realizations of the cosmic 21cm signal.
Submitting author: @steven-murray
Handling editor: @dfm (Active)
Reviewers: @sambit-giri, @sultan-hassan
Similarity score: 0.6915

pygwb: a Python-based library for gravitational-wave background searches
Submitting author: @a-renzini
Handling editor: @plaplant (Active)
Reviewers: @Sbozzolo, @cmbiwer
Similarity score: 0.6914

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.6887

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@warrickball
Copy link

Hi @silvanfischbacher, thanks for your submissions to JOSS and my apologies for taking so long to initiate the pre-review.

Because this is a co-publication, for this submission and UFig I'm going to ask the editorial board to consider whether the implementation of the software itself reflects a substantial scientific effort, as indicated in our docs. This should take a week or two. Sorry for the further delay!

@warrickball
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review PureBasic Python query-scope Submissions of uncertain scope for JOSS TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

3 participants