Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AquaCrop.jl: A Process-Based Model of Crop Growth #7704

Open
editorialbot opened this issue Jan 21, 2025 · 11 comments
Open

[PRE REVIEW]: AquaCrop.jl: A Process-Based Model of Crop Growth #7704

editorialbot opened this issue Jan 21, 2025 · 11 comments

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @gabo-di (Gabriel Diaz Iturry)
Repository: https://github.com/gabo-di/AquaCrop.jl
Branch with paper.md (empty if default branch): paper
Version: 0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/31c4de709e9417547f7f0455c7b6e773"><img src="https://joss.theoj.org/papers/31c4de709e9417547f7f0455c7b6e773/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/31c4de709e9417547f7f0455c7b6e773/status.svg)](https://joss.theoj.org/papers/31c4de709e9417547f7f0455c7b6e773)

Author instructions

Thanks for submitting your paper to JOSS @gabo-di. Currently, there isn't a JOSS editor assigned to your paper.

@gabo-di if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Jan 21, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.agwat.2016.11.015 is OK
- 10.2134/agronj2008.0218s is OK
- 10.1017/S0021859621000216 is OK
- 10.1038/s41597-024-03051-3 is OK
- 10.1007/978-3-030-66387-2_11 is OK
- 10.2134/agronj2008.0140s is OK
- 10.2134/agronj2008.0139s is OK
- 10.5194/gmd-14-7309-2021 is OK
- 10.1002/pan3.10472 is OK
- 10.18174/sesmo.18701 is OK
- 10.1016/j.agwat.2021.106976 is OK
- 10.3390/agronomy9070378 is OK
- 10.1137/141000671 is OK
- 10.21105/joss.03349 is OK
- 10.1038/nature10452 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: AquaCrop Training Handbooks - Book I. Understandin...
- No DOI given, and none found for title: AquaCrop Repository
- No DOI given, and none found for title: Persefone.Jl

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.22 s (285.1 files/s, 159564.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           25           2736           3405          22455
CSV                              5              0              0           3386
TOML                            18            120            128            931
Markdown                         7            231              0            807
TeX                              1             21              0            300
YAML                             5              1              8            173
Text                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            62           3109           3541          28053
-------------------------------------------------------------------------------

Commit count by author:

    84	gabo-di
    77	Gabriel Diaz Iturry
    23	Daniel Vedder
     3	Martijn Visser
     2	CompatHelper Julia
     2	Marco Matthies
     1	dependabot[bot]

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1390

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Climate variability indices for ecological and crop models in R: the climatrends package
Submitting author: @kauedesousa
Handling editor: @KristinaRiemer (Retired)
Reviewers: @dlebauer, @istfer
Similarity score: 0.6811

PlanktonIndividuals.jl: A GPU supported individual-based phytoplankton life cycle model
Submitting author: @zhenwu0728
Handling editor: @elbeejay (Active)
Reviewers: @Datseris, @BrodiePearson
Similarity score: 0.6791

WorldDynamics.jl: A Julia Package for Developing and Simulating Integrated Assessment Models
Submitting author: @aurorarossi
Handling editor: @fraukewiese (Active)
Reviewers: @ranocha, @StanczakDominik, @miguelraz
Similarity score: 0.6747

AIBECS.jl: A tool for exploring global marine biogeochemical cycles.
Submitting author: @briochemc
Handling editor: @kthyng (Active)
Reviewers: @dankelley, @zhenwu0728
Similarity score: 0.6639

SimpleSDMLayers.jl and GBIF.jl: A Framework for Species Distribution Modeling in Julia
Submitting author: @gabrieldansereau
Handling editor: @KristinaRiemer (Retired)
Reviewers: @dglmoore, @marcjwilliams1
Similarity score: 0.6591

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@veddox
Copy link

veddox commented Jan 22, 2025

Reviewer suggestions:

From JOSS reviewer list: Rémi Vezy, tonyewong, Julien Jean Malard-Adam

Other potential reviewers: Louise Busschaert (University of Leuven, codeveloper on the original Fortran version of the software), Han Su (University of Twente, has expressed interest in using AquaCrop.jl), Martijn Visser (Deltares, has expressed interest in using AquaCrop.jl)

@kthyng
Copy link

kthyng commented Jan 27, 2025

Hi @gabo-di and @veddox and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

@kthyng
Copy link

kthyng commented Jan 27, 2025

For reviewer suggestions, please be sure to include their github handles!

@gabo-di
Copy link

gabo-di commented Jan 28, 2025

Hello @kthyng,

Reviewer suggestions:

  • From JOSS:

    1. (@)VEZY
    2. (@)tonyewong
    3. (@)julienmalard
  • Other potential reviewers:

    1. Louise Busschaert (@)lbusschaert (University of Leuven, codeveloper on the original Fortran version of the software).
    2. Martijn Visser (@)visr (Deltares, has expressed interest in using AquaCrop.jl)
    3. Han Su (email: [email protected])) (University of Twente, has expressed interest in using AquaCrop.jl)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants