Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SSAPy - Space Situational Awareness for Python #7699

Open
editorialbot opened this issue Jan 20, 2025 · 7 comments
Open

[PRE REVIEW]: SSAPy - Space Situational Awareness for Python #7699

editorialbot opened this issue Jan 20, 2025 · 7 comments
Labels
pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @astrophpeter (Peter McGill)
Repository: https://github.com/LLNL/SSAPy
Branch with paper.md (empty if default branch):
Version: v0.7.0
Editor: Pending
Reviewers: Pending
Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a629353cbdd8d64a861bb807e12c5d06"><img src="https://joss.theoj.org/papers/a629353cbdd8d64a861bb807e12c5d06/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a629353cbdd8d64a861bb807e12c5d06/status.svg)](https://joss.theoj.org/papers/a629353cbdd8d64a861bb807e12c5d06)

Author instructions

Thanks for submitting your paper to JOSS @astrophpeter. Currently, there isn't a JOSS editor assigned to your paper.

@astrophpeter if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jan 20, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=2.17 s (33.3 files/s, 345223.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SQL                              1              0              0         721801
Python                          33           3028           6597          12065
reStructuredText                10            303            221            495
TeX                              2             44              0            388
HTML                             1             93             26            276
C++                              2             32             11            253
Markdown                         7             49              0            196
SVG                              1              0              0            154
YAML                             2             10             40            144
Jupyter Notebook                 2              0            612            119
C/C++ Header                     1             26            118             99
C                                1              5              8             62
Dockerfile                       1              7              6             43
Text                             5              2              0             41
CMake                            1              2              1             21
make                             1              5              8             11
CSV                              1              0              0              7
-------------------------------------------------------------------------------
SUM:                            72           3606           7648         736175
-------------------------------------------------------------------------------

Commit count by author:

    25	Alexx Perloff
    11	Jason Bernstein
     9	Travis Yeager
     8	Imène Goumiri
     2	yeager7
     1	Ben Breisch
     1	Ephraim
     1	Kerianne Pruett
     1	Peter McGill

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Joshua Meyers, perhaps the affiliations index need quoting?.

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 812

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.2172/1825370 is OK
- 10.1109/AERO.2019.8741766 is OK
- 10.5281/zenodo.12785036 is OK
- 10.5281/zenodo.10023045 is OK
- 10.1109/LSP.2021.3139572 is OK
- 10.1051/0004-6361/201118085 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1086/670067 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.3847/1538-4357/ac7c74 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Memorandum of Understanding between the National A...
- No DOI given, and none found for title: python-sgp4
- No DOI given, and none found for title: Long-term N-body Stability in Cislunar Space
- No DOI given, and none found for title: SOM-erizing Cislunar Orbits: Classification of Cis...
- No DOI given, and none found for title: Closely-Spaced Object Classification Using MuyGPyS
- No DOI given, and none found for title: Long-term N-body Stability in Cislunar Space

❌ MISSING DOIs

- 10.2514/6.2006-6753 may be a valid DOI for title: Revisiting spacetrack report# 3
- 10.2514/6.2014-4151 may be a valid DOI for title: Verification and validation of the general mission...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@warrickball
Copy link

Hi @astrophpeter — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, could you also try changing the affiliation list for Joshua E. Myers from [1, 2] to "1, 2", then rerun our paper pipeline by commenting here with @editorialbot generate pdf? If that does fix the error, as the pipeline suggests, then there's an error in our documentation that I'll fix.

I also had a brief look at SSAPy's documentation and noticed that the API reference doesn't seem to have any content beyond the top-level modules. I presume that indicates a bug in the documentation pipeline.

@warrickball warrickball added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

2 participants