Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PyNomaly #730

Closed
whedon opened this issue May 9, 2018 · 32 comments
Closed

[PRE REVIEW]: PyNomaly #730

whedon opened this issue May 9, 2018 · 32 comments

Comments

@whedon
Copy link

whedon commented May 9, 2018

Submitting author: @vc1492a (Valentino Constantinou)
Repository: https://www.github.com/vc1492a/PyNomaly
Version: v0.2.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @yzhao062

Author instructions

Thanks for submitting your paper to JOSS @vc1492a. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@vc1492a if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 9, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented May 9, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 9, 2018

@arfon
Copy link
Member

arfon commented May 14, 2018

👋@vc1492a - it looks like you're missing references in this paper. Is there nothing you wish to cite?

@vc1492a
Copy link

vc1492a commented May 14, 2018

@arfon I was under the impression that references should be included in paper.bib. The examples linked from the JOSS website show references in paper.bib and not in paper.md. Should I also add my references to paper.md?

@arfon
Copy link
Member

arfon commented May 14, 2018

@vc1492a - I think the issue is that you're not citing them directly (so they're not showing up in the compiled PDF). You can read how to do that here

@vc1492a
Copy link

vc1492a commented May 15, 2018

@afron thanks for the helpful link. I've updated my citations in paper.md, let me know if it looks good to you.

@arfon
Copy link
Member

arfon commented May 15, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 15, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 15, 2018

@arfon
Copy link
Member

arfon commented May 15, 2018

@whedon list reviewers

@whedon
Copy link
Author

whedon commented May 15, 2018

Here's the current list of reviewers: https://bit.ly/joss-reviewers

@arfon
Copy link
Member

arfon commented May 15, 2018

@vc1492a - could you take a look at the list of potential reviewers above and suggest a few that might be appropriate for your submission? ☝️

@vc1492a
Copy link

vc1492a commented May 15, 2018

@arfon I took a look at the list of potential reviewers. Here are my suggestions:

  • jkahn
  • desilinguist
  • krother

@vc1492a
Copy link

vc1492a commented May 17, 2018

@arfon I've made one small minor adjustment to fix a typo, in case you need to generate a new proof.

@arfon
Copy link
Member

arfon commented May 19, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 19, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 19, 2018

@arfon
Copy link
Member

arfon commented May 19, 2018

@mlgill @sssomani - would you be willing to review this submission for JOSS?

@mlgill
Copy link

mlgill commented May 19, 2018

@arfon sorry, I don’t have much experience with this topic.

@sssomani
Copy link

sssomani commented May 19, 2018 via email

@arfon
Copy link
Member

arfon commented May 20, 2018

@nhejazi @fritzo - would you be willing to review this submission for JOSS?

@arfon
Copy link
Member

arfon commented Jun 25, 2018

@jkahn - would you be willing to review this submission for JOSS?

@Kevin-Mattheus-Moerman
Copy link
Member

@yzhao062 @betatim @aqibsaeed @rhiever would you be willing to review this submission for JOSS? The review process focuses largely on the software and a short paper.

--> The paper 📄 <--

--> The project repo 💾 : <--

@yzhao062
Copy link

@Kevin-Mattheus-Moerman I am happy to review PyNomaly since I used it in one of my previous research. Just need to get familiar with the review process :)

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Jun 25, 2018

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @yzhao062 as reviewer

@whedon
Copy link
Author

whedon commented Jun 25, 2018

OK, the reviewer is @yzhao062

@Kevin-Mattheus-Moerman
Copy link
Member

@yzhao062 great thanks. I've added you as reviewer and will attempt to recruit a few more. Let me know if you have questions about the review process. This issue here is a so called pre-review issue. Once we have sufficient reviewers we'll move on to a review issue where the actual review takes place. I'll ping you there when we are ready.
The review process is guided by a set of tickboxes for each reviewer. Here is a nice example of a finished review process: #726
As you can see the reviewers comment in the review issue to provide feedback but also create PR's or issues on the project repository as well.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Jul 24, 2018

OK, I've started the review over in #845. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants