-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Giga Connectome: a BIDS-app for time series and functional connectome extraction #7061
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
👋🏼 @htwangtw, @jdkent, @shnizzedy this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
at the top of a new comment in this thread. There are additional guidelines in the message at the start of this issue. Please feel free to ping me (@mstimberg) if you have any questions/concerns. |
|
Review checklist for @jdkentConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@mstimberg I was unaware of this work prior to being invited to review. I think I am able to make an impartial assessment of this work and request that these conflicts be waived: Conflicts of interest
ReferencesFootnotes
|
@shnizzedy Many thanks for the detailed information. From my side, I'd say that the last point is not an issue (it regularly happens that reviewers are authors of software in the same field that get cited by the reviewed manuscript). I am also not worried about all of you being part of the Brainhack community – reviewers and authors being part of the same community is difficult to avoid if we want to have competent reviewers 😊 CC @sappelhoff who is both a JOSS editor and a BIDS maintainer, so he might have valuable insights to add. |
I agree ✅ I believe the COI for @shnizzedy can be waived. |
@editorialbot add @emullier as reviewer Thanks for joining us! |
@emullier added to the reviewers list! |
Review checklist for @emullierConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @jdkent and @emullier, did you already have a chance to have a closer look at the software and paper? Please be reminded of our review recommendations:
@htwangtw: please have another look at the issues opened by @shnizzedy and update their status (e.g. close them) if necessary 🙏 |
Hi @mstimberg, I started to play with the software 2 days ago, I currently have some issues running it on my subject |
Thanks for the reminder - I will get back on to this soon! |
@mstimberg I think it would be best to remove @shnizzedy as a reviewer. There does seem to be either a potential or perceived COI, especially relating to the shared authorship and consortium membership which show a prolonged collaboration. @shnizzedy thanks for sharing this information, and thanks for offering to help. Unfortunately our policies are quite strict on potential/perceived COIs. Hence we will proceed to remove you as reviewer. We do hope we may ask for your assistance for a different JOSS submission in the future. Thanks agian. |
Dear @shnizzedy, apologies that this took so long, and even more apologies that the final decision is contrary to what I indicated earlier. As @Kevin-Mattheus-Moerman explained above, we finally consider your closeness to some of the authors as being a potential COI – or at least perceivable as one. I therefore regret that I'll have to officially remove you as a reviewer. Thanks a million for your involvement, though, and I'd be very happy to see you come back to JOSS as a reviewer (or author) another time. @htwangtw Of course, this does not mean that you have to discard the issues opened by @shnizzedy, please feel free to address them as you see fit. |
@editorialbot remove @shnizzedy from reviewers |
@shnizzedy removed from the reviewers list! |
👋 @emullier did you find time to have another look at the software? Please note that the authors have replied in the two issues you opened (bids-apps/giga_connectome#171 and bids-apps/giga_connectome#171). @jdkent Can you please give us an estimate when you will be able to review this submission? |
@emullier & @jdkent, could you please give us an update ?
|
I will try to look for any potential blockers this week. Really sorry for the delay on my side too |
apologies on my long delay, I am walking through the code and documentation now and will be done by the end of this week. |
I have a few nitpicks as issues in the repository, but I do not see those as a reason to hold back the publication of this software in JOSS. |
Many thanks for your review, @jdkent. Just for reference, here the links to the issues you opened: bids-apps/giga_connectome#184, bids-apps/giga_connectome#185, bids-apps/giga_connectome#186 As you said, these do not seem to be major issues, but I'd suggest that the authors have a look at them and see whether they can be addressed easily. |
👋 Hi and a belated Happy New Year (or a not so belated Chinese New Year for all those who celebrate) 🎆 ! @emullier could you please give us an update:
@jdkent I think that @htwangtw addressed the issues that you opened, could you please have a look whether these solutions/answers work for you and update your checklist if necessary? Thanks 🙏 ! |
Thank you for following up @mstimberg I am going to have some further updates as some of the issues opened by @emullier can be addressed with improved documentation. Thank you all for the patience! |
Submitting author: @htwangtw (Hao-Ting Wang)
Repository: https://github.com/bids-apps/giga_connectome
Branch with paper.md (empty if default branch):
Version: 0.5.0
Editor: @mstimberg
Reviewers: @jdkent, @emullier
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jdkent & @shnizzedy, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mstimberg know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jdkent
📝 Checklist for @shnizzedy
📝 Checklist for @emullier
The text was updated successfully, but these errors were encountered: